fix(api): ignore deprecated timeout arg provided to is_visible/hidden #2905
+40
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
approved these changes
Jun 26, 2025
|
Can the argument just be removed already? It's been years since it was deprecated and silently ignoring the argument is much worse than crashing at runtime because it makes it much more difficult and confusing for the user if they don't notice the deprecation message. When I updated to playwright 1.53 this crash identified many places in our codebase where we were incorrectly passing the timeout argument, which I was then able to easily fix. Ignoring the argument makes these bugs go undetected. See my reasoning in microsoft/playwright#33017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2904
Ignore
timeoutargs passed to anyis_visible()/is_hidden()call.