fix: prevent ProtocolCallback memory leak during tracing (#2977) #2980
+66
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
fix/protocol-callback-memory-leak
branch
2 times, most recently
from
1e5fcaf to
714207c
Compare
dgozman
approved these changes
Sep 29, 2025
Fix memory leak where ProtocolCallback objects accumulated when tracing was enabled. The issue affected both sync and async Playwright, but was more severe in async usage where callbacks persisted permanently. - When tracing is enabled, send_no_reply() creates ProtocolCallback objects - These callbacks have circular references via task cancellation handlers - For no_reply messages, futures are never resolved, preventing GC cleanup - Each page operation during tracing leaked ~10 callbacks permanently - Add no_reply parameter to ProtocolCallback constructor - For no_reply=True: skip cancellation setup and resolve future immediately - For no_reply=False: use full constructor with cancellation handling - Update dispatch() to handle missing callbacks gracefully - Added regression test in test_reference_count_async.py - Test fails before fix (30+ leaked callbacks) and passes after (≤5) - All existing tracing and asyncio tests continue to pass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
mxschmitt
force-pushed
the
fix/protocol-callback-memory-leak
branch
from
714207c to
90f062e
Compare
dgozman
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak where ProtocolCallback objects accumulated when tracing was enabled. The issue affected both sync and async Playwright, but was more severe in async usage where callbacks persisted permanently.
Root Cause
Solution
Testing
Fixes #2977