Skip to content

chore(cli): self-documenting cli.config.json#40081

Open
Skn0tt wants to merge 2 commits intomicrosoft:mainfrom
Skn0tt:jsonc
Open

chore(cli): self-documenting cli.config.json#40081
Skn0tt wants to merge 2 commits intomicrosoft:mainfrom
Skn0tt:jsonc

Conversation

@Skn0tt
Copy link
Copy Markdown
Member

@Skn0tt Skn0tt commented Apr 7, 2026

No description provided.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.


import type * as playwright from '../../..';

// This file contains type declarations for the MCP and CLI config. Please keep the following files in sync:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is copied verbatim to microsoft/playwright-mcp repo, so let's not have internal comments inside.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the comment so that agents know to keep the other one updated. Why are you concerned about adding it to the other repo?

},

// List of enabled tool capabilities.
// Possible values: "config", "core", "core-navigation", "core-tabs",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to imagine this list of possible values will be kept in sync.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we have the comment, I'd hope the agent keeps it in sync 🤷

@Skn0tt Skn0tt requested a review from dgozman April 7, 2026 14:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:397 › should not preserve selection across test runs @macos-latest-node20

8 flaky ⚠️ [chromium-library] › library/video.spec.ts:481 › screencast › should capture static page in persistent context @smoke `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/video.spec.ts:280 › screencast › should capture navigation `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:652 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:687 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:118 › screencast › should capture static page `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/video.spec.ts:724 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`

39138 passed, 846 skipped


Merge workflow run.

@github-actions

This comment has been minimized.

@Skn0tt
Copy link
Copy Markdown
Member Author

Skn0tt commented Apr 8, 2026

I'll wait to for the bundles to settle before continuing this.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "MCP"

6533 passed, 383 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants