Fix radio extension's "more" toolbox display #6824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The raiseEvent block was referencing block ids control_event_source_id and control_event_value_id which don't exist in common packages. I didn't remove the code completely in case anyone already has this block in their project, but I don't think we need to show it. In live, it's already basically impossible to access because it messes up the toolbox load. One unknown is if this is needed by micro:bit, which does actually have the block ids. If that's the case, correct fix may be to actually bring the missing block into common packages instead. This is an auto-generated change based on a change in pxt-common-packages branch thsparks/fix_radio_more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated block info, automatically built from microsoft/pxt-common-packages#1505.