Skip to content

Conversation

@Kikketer
Copy link
Contributor

Reported in the arcade-sprite-data plugin microsoft/arcade-sprite-data#6.

The upgrade is a string but should be an array. This prevents the warning:

invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> m
invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> i
invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> n
invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> :
invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> v
invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> 0
invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> .
invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> 0
invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> .
invalid upgrade rule: github:microsoft/arcade-sprite-data#v0.2.1 -> 6

@abchatra abchatra requested review from Copilot and jwunderl October 23, 2025 17:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a data type issue in the targetconfig.json file where the upgrades field was incorrectly specified as a string instead of an array. This was causing the system to iterate over each character of the string, generating invalid upgrade rule warnings for each character.

Key Changes:

  • Corrected the upgrades field format from a string to an array for the microsoft/arcade-sprite-data package configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@riknoll riknoll merged commit 6652129 into microsoft:master Oct 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants