Skip to content

Conversation

@Kikketer
Copy link
Contributor

@Kikketer Kikketer commented Oct 19, 2025

Release actions consistently fail and any changes within your repo to fix it are overwritten when we create a release in the GUI.

This updates the github action to use modern node, no matrix (not needed) and uses modern and supported ways of uploading the assets to the release

Tested and proven here: https://github.com/Emeraldtheporcupine/GelbsBunnyHunt/actions/runs/18633872295
Undone by the release button here: https://github.com/Emeraldtheporcupine/GelbsBunnyHunt/actions/runs/18634404746

@abchatra abchatra requested review from Copilot and jwunderl October 23, 2025 17:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the GitHub Actions release workflow to use modern Node.js (v22) and supported GitHub CLI commands for asset uploads. The changes address recurring failures in the release action by eliminating the deprecated node-version matrix strategy and replacing the deprecated actions/upload-release-asset action with the GitHub CLI gh release upload command.

Key Changes

  • Upgraded to Node.js 22 and modern GitHub Actions (checkout@v5, setup-node@v6)
  • Replaced deprecated upload-release-asset action with GitHub CLI for uploading multiple release assets
  • Added explicit contents: write permission required for release uploads

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@WoofWoofCodes WoofWoofCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! If this prevents those Release Failed emails, it's much appreciated!

@Kikketer
Copy link
Contributor Author

Kikketer commented Oct 24, 2025

@riknoll or @jwunderl I can't merge due to the buildpush failure in the flow. Could you override that or is there something I should adjust to get that validation to pass?

Kind of looking at that as my next plan of attack :)

@riknoll
Copy link
Member

riknoll commented Oct 24, 2025

@Kikketer hmmmm... not sure why the workflow is failing but it certainly isn't for any good reason. i'll merge this

@riknoll riknoll merged commit 20c6324 into microsoft:master Oct 24, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants