Adaptive Profile support for CPU-full-state and Clifford simulators#3086
Open
orpuente-MS wants to merge 11 commits intomainfrom
Open
Adaptive Profile support for CPU-full-state and Clifford simulators#3086orpuente-MS wants to merge 11 commits intomainfrom
orpuente-MS wants to merge 11 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
orpuente-MS
commented
Apr 3, 2026
Comment on lines
+261
to
+278
| # Override s, s_adj, and z noise if they are unset | ||
| # and rz noise is set. | ||
| if noise and not noise.rz.is_noiseless(): | ||
| if noise.s.is_noiseless(): | ||
| noise.s.x = noise.rz.x | ||
| noise.s.y = noise.rz.y | ||
| noise.s.z = noise.rz.z | ||
| noise.s.loss = noise.rz.loss | ||
| if noise.s_adj.is_noiseless(): | ||
| noise.s_adj.x = noise.rz.x | ||
| noise.s_adj.y = noise.rz.y | ||
| noise.s_adj.z = noise.rz.z | ||
| noise.s_adj.loss = noise.rz.loss | ||
| if noise.z.is_noiseless(): | ||
| noise.z.x = noise.rz.x | ||
| noise.z.y = noise.rz.y | ||
| noise.z.z = noise.rz.z | ||
| noise.z.loss = noise.rz.loss |
Contributor
Author
There was a problem hiding this comment.
This logic was previously in cpu_simulators.rs, but it is very specific to the device; now that the run_qir function is being used more widely, it makes sense to move it here. Also, the GPU simulator was missing this logic, putting it here makes it common for all simulators available to the NeutralAtomDevice class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the work in #3039 by adding Adaptive Profile support for the CPU-full-state and Clifford simulators.
It also fixes a bug in which the GPU simulator was not using dynamic angles for rotation gates.