[heft] Stop using true-case-path #4969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
D4N14L,
apostolisms,
iclanton,
octogonz and
patmill
as code owners
iclanton
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove usage of
true-case-pathin Heft.Details
The implementation of
true-case-pathperforms directory enumeration of every folder between the file system root and heft's working directory. Usage of this tool was motivated by issues with drive letter casing normalization on Windows, but the implementation of doing so in true-case-path is just a hardcoded "if on Windows, uppercase the drive letter", so we may as well just do the same directly.The directory enumerations cause problems when running inside of build systems that monitor file system accesses, since they cause the system to see the process as enumerating root-level folders.
How it was tested
The pipelines for this PR cover Heft sufficiently.
Impacted documentation
None.