Skip to content

Fix intermittent deadlock in AnsiTerminal_OutputProgressFrameIsCorrect #7584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 2 commits into from
Mar 20, 2026
Merged

Fix intermittent deadlock in AnsiTerminal_OutputProgressFrameIsCorrect #7584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a3778
Initial plan
Copilot Mar 20, 2026
8dd662c
Fix deadlock in TestProgressStateAwareTerminal.ThreadProc causing tes…
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...atform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressStateAwareTerminal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,12 @@ private void ThreadProc()
const int AnsiUpdateCadenceInMs = 500;
while (!_cts.Token.WaitHandle.WaitOne(AnsiUpdateCadenceInMs))
{
// Note: OnProgressStartUpdate is invoked outside the lock to avoid a deadlock where
// a test subscriber blocks the event handler (e.g. with WaitOne) while the lock is held,
// preventing other callers (e.g. WriteToTerminal) from acquiring the lock.
OnProgressStartUpdate?.Invoke(this, EventArgs.Empty);
lock (_lock)
{
OnProgressStartUpdate?.Invoke(this, EventArgs.Empty);
_terminal.StartUpdate();
try
{
Expand Down
Loading