Always provide ModuleSpecifierGenerationHost to NodeBuilder#1604
Merged
jakebailey merged 25 commits intomainfrom Feb 10, 2026
Merged
Always provide ModuleSpecifierGenerationHost to NodeBuilder#1604jakebailey merged 25 commits intomainfrom
jakebailey merged 25 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the Go port’s NodeBuilder module-specifier generation behavior with upstream TypeScript (per microsoft/TypeScript#62726), resulting in more stable/appropriate emitted import specifiers and updated baselines.
Changes:
- Always provide a module-specifier generation host to NodeBuilder via context, removing the
GetModuleSpecifierGenerationHostrequirement from symbol trackers. - Adjust module specifier/path comparison behavior to improve determinism.
- Update many compiler baseline files to reflect the new specifier generation behavior.
Reviewed changes
Copilot reviewed 298 out of 1391 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/checker/nodebuilder.go | Store a host on NodeBuilder and pass it into each new NodeBuilderContext. |
| internal/checker/nodebuilderimpl.go | Use ctx.host instead of tracker.GetModuleSpecifierGenerationHost() when generating module specifiers. |
| internal/checker/symboltracker.go | Simplify NewSymbolTrackerImpl by removing module-specifier host plumbing. |
| internal/nodebuilder/types.go | Remove module-specifier host getter from the SymbolTracker interface. |
| internal/transformers/declarations/tracker.go | Remove now-unneeded GetModuleSpecifierGenerationHost implementation wiring. |
| internal/modulespecifiers/util.go | Add tie-breaker comparison for redirected paths when normalized comparisons are equal. |
| internal/fourslash/_scripts/manualTests.txt | Update manual test list (but currently contains merge-conflict markers). |
| testdata/baselines/reference/submodule/compiler/jsdocReferenceGlobalTypeInCommonJs.types | Baseline update for module specifier formatting. |
| testdata/baselines/reference/submodule/compiler/jsdocReferenceGlobalTypeInCommonJs.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/jsdocReferenceGlobalTypeInCommonJs.symbols | Baseline update for symbol display names. |
| testdata/baselines/reference/submodule/compiler/jsdocPropertyTagInvalid.types.diff | Baseline update for import type specifiers. |
| testdata/baselines/reference/submodule/compiler/jsdocPropertyTagInvalid.types | Baseline update for import type specifiers. |
| testdata/baselines/reference/submodule/compiler/jsFileCompilationExternalPackageError.types.diff | Baseline diff update due to specifier resolution changes. |
| testdata/baselines/reference/submodule/compiler/jsFileCompilationExternalPackageError.types | Baseline update for exports import type specifier. |
| testdata/baselines/reference/submodule/compiler/jsFileCompilationExternalPackageError.symbols.diff | Baseline update for symbol names. |
| testdata/baselines/reference/submodule/compiler/jsFileCompilationExternalPackageError.symbols | Baseline update for symbol names. |
| testdata/baselines/reference/submodule/compiler/jsFileClassPropertyInitalizationInObjectLiteral.symbols.diff | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/jsFileClassPropertyInitalizationInObjectLiteral.symbols | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation3.types.diff | Baseline update for module import specifiers in CommonJS patterns. |
| testdata/baselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation3.types | Baseline update for module import specifiers in CommonJS patterns. |
| testdata/baselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation3.symbols.diff | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation3.symbols | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation2.symbols.diff | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation2.symbols | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation.symbols.diff | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsExportMemberMergedWithModuleAugmentation.symbols | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsExportAssignmentNonMutableLocation.types.diff | Baseline update for import specifiers. |
| testdata/baselines/reference/submodule/compiler/jsExportAssignmentNonMutableLocation.types | Baseline update for import specifiers. |
| testdata/baselines/reference/submodule/compiler/jsExportAssignmentNonMutableLocation.symbols.diff | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsExportAssignmentNonMutableLocation.symbols | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsEnumTagOnObjectFrozen.types | Baseline update for require/export import typing. |
| testdata/baselines/reference/submodule/compiler/jsEnumTagOnObjectFrozen.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/jsDocDeclarationEmitDoesNotUseNodeModulesPathWithoutError.types.diff | Baseline diff update for node_modules path handling. |
| testdata/baselines/reference/submodule/compiler/jsDocDeclarationEmitDoesNotUseNodeModulesPathWithoutError.types | Baseline update for node_modules path handling. |
| testdata/baselines/reference/submodule/compiler/jsDeclarationsWithDefaultAsNamespaceLikeMerge.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/jsDeclarationsWithDefaultAsNamespaceLikeMerge.types | Baseline update for relative specifiers. |
| testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.symbols.diff | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedFunctionWithExtraTypedefsMembers.symbols | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedArray.symbols.diff | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsDeclarationEmitExportAssignedArray.symbols | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/jsDeclarationEmitDoesNotRenameImport.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/jsDeclarationEmitDoesNotRenameImport.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/javascriptImportDefaultBadExport.symbols.diff | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/javascriptImportDefaultBadExport.symbols | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/javascriptCommonjsModule.symbols.diff | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/javascriptCommonjsModule.symbols | Baseline update for module symbol names. |
| testdata/baselines/reference/submodule/compiler/isolatedModulesReExportType.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/isolatedModulesReExportType.types | Baseline update for relative import type. |
| testdata/baselines/reference/submodule/compiler/isolatedDeclarationErrorsAugmentation.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/isolatedDeclarationErrorsAugmentation.types | Baseline update for augmentation import type. |
| testdata/baselines/reference/submodule/compiler/isolatedDeclarationErrorsAugmentation.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/isolatedDeclarationErrorsAugmentation.symbols | Baseline update for augmentation symbol naming. |
| testdata/baselines/reference/submodule/compiler/inferrenceInfiniteLoopWithSubtyping.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/inferrenceInfiniteLoopWithSubtyping.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/importedEnumMemberMergedWithExportedAliasIsError.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/importedEnumMemberMergedWithExportedAliasIsError.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/importUsedInGenericImportResolves.types.diff | Baseline update for error/type display. |
| testdata/baselines/reference/submodule/compiler/importUsedInGenericImportResolves.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/importTypeResolutionJSDocEOF.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/importTypeResolutionJSDocEOF.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/importShouldNotBeElidedInDeclarationEmit.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/importShouldNotBeElidedInDeclarationEmit.types | Baseline update to avoid node_modules paths in specifiers. |
| testdata/baselines/reference/submodule/compiler/importPropertyFromMappedType.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/importPropertyFromMappedType.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/importNonExportedMember12.symbols.diff | Baseline update for package import naming. |
| testdata/baselines/reference/submodule/compiler/importNonExportedMember12.symbols | Baseline update for package import naming. |
| testdata/baselines/reference/submodule/compiler/importHelpersWithExportStarAs(esmoduleinterop=true,module=es2020).types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/importHelpersWithExportStarAs(esmoduleinterop=true,module=es2020).types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/importHelpersWithExportStarAs(esmoduleinterop=true,module=es2015).types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/importHelpersWithExportStarAs(esmoduleinterop=true,module=es2015).types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/importHelpersWithExportStarAs(esmoduleinterop=true,module=commonjs).types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/importHelpersWithExportStarAs(esmoduleinterop=true,module=commonjs).types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/importHelpersCommonJSJavaScript(verbatimmodulesyntax=true).symbols.diff | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/importHelpersCommonJSJavaScript(verbatimmodulesyntax=true).symbols | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/importHelpersCommonJSJavaScript(verbatimmodulesyntax=false).symbols.diff | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/importHelpersCommonJSJavaScript(verbatimmodulesyntax=false).symbols | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/giant.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/giant.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/functionExpressionNames.types.diff | Baseline update for CommonJS exports typing/specifiers. |
| testdata/baselines/reference/submodule/compiler/functionExpressionNames.types | Baseline update for CommonJS exports typing/specifiers. |
| testdata/baselines/reference/submodule/compiler/functionExpressionNames.symbols.diff | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/functionExpressionNames.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/expressionsForbiddenInParameterInitializers.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/expressionsForbiddenInParameterInitializers.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/expressionsForbiddenInParameterInitializers.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/expressionsForbiddenInParameterInitializers.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/exportStarNotElided.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/exportStarNotElided.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportInterfaceClassAndValue.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/exportInterfaceClassAndValue.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportEqualsProperty.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportEqualsProperty.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportEqualMemberMissing.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportEqualMemberMissing.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportEqualErrorType.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportEqualErrorType.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportDefaultWithJSDoc2.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/exportDefaultWithJSDoc2.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportDefaultWithJSDoc1.types.diff | Baseline diff update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/exportDefaultWithJSDoc1.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportDefaultProperty.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportDefaultProperty.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportClassExtendingIntersection.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportAssignmentMembersVisibleInAugmentation.types.diff | Baseline diff update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/exportAssignmentMembersVisibleInAugmentation.types | Baseline update to keep package specifier stable. |
| testdata/baselines/reference/submodule/compiler/exportAssignedNamespaceIsVisibleInDeclarationEmit.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/exportAssignedNamespaceIsVisibleInDeclarationEmit.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportAssignClassAndModule.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportAssignClassAndModule.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportAsNamespace_augment.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/exportAsNamespace_augment.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/exportAsNamespace.d.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/exportAsNamespace.d.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/expandoFunctionSymbolPropertyJs.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/expandoFunctionSymbolPropertyJs.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/expandoFunctionContextualTypesJs.symbols.diff | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/expandoFunctionContextualTypesJs.symbols | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/esmNoSynthesizedDefault(module=preserve).types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/esmNoSynthesizedDefault(module=preserve).types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/esmNoSynthesizedDefault(module=preserve).symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/esmNoSynthesizedDefault(module=preserve).symbols | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/esmNoSynthesizedDefault(module=esnext).types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/esmNoSynthesizedDefault(module=esnext).types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/esmNoSynthesizedDefault(module=esnext).symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/esmNoSynthesizedDefault(module=esnext).symbols | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/esModuleIntersectionCrash.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/esModuleIntersectionCrash.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/esModuleInteropImportCall.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/esModuleInteropImportCall.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/es6ExportClauseWithoutModuleSpecifierInEs5(target=es2015).types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/es6ExportClauseWithoutModuleSpecifierInEs5(target=es2015).types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/es6ExportClauseWithoutModuleSpecifier.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/es6ExportClauseWithoutModuleSpecifier.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/es5ExportEqualsDts(target=es2015).types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/es5ExportEqualsDts(target=es2015).types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/errorForConflictingExportEqualsValue.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/errorForConflictingExportEqualsValue.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/enumAssignmentCompat6.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/enumAssignmentCompat6.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/ensureNoCrashExportAssignmentDefineProperrtyPotentialMerge.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/dynamicImportsDeclaration.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/dynamicImportsDeclaration.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/duplicatePackage_relativeImportWithinPackage_scoped.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/duplicatePackage_relativeImportWithinPackage_scoped.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/duplicatePackage_relativeImportWithinPackage.types.diff | Baseline update for duplicate package path rendering. |
| testdata/baselines/reference/submodule/compiler/duplicatePackage_relativeImportWithinPackage.types | Baseline update for duplicate package path rendering. |
| testdata/baselines/reference/submodule/compiler/duplicatePackage.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/duplicatePackage.types | Baseline update for duplicate package path rendering. |
| testdata/baselines/reference/submodule/compiler/duplicateIdentifierRelatedSpans_moduleAugmentation.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/duplicateIdentifierRelatedSpans_moduleAugmentation.types | Baseline update for augmentation module specifiers. |
| testdata/baselines/reference/submodule/compiler/duplicateIdentifierRelatedSpans_moduleAugmentation.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/duplicateIdentifierRelatedSpans_moduleAugmentation.symbols | Baseline update for augmentation symbol naming. |
| testdata/baselines/reference/submodule/compiler/declareFileExportAssignmentWithVarFromVariableStatement.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declareFileExportAssignmentWithVarFromVariableStatement.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declareFileExportAssignment.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declareFileExportAssignment.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationsIndirectGeneratedAliasReference.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationsIndirectGeneratedAliasReference.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/declarationsForInferredTypeFromOtherFile.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationsForInferredTypeFromOtherFile.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationMapsWithoutDeclaration.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationMapsWithoutDeclaration.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationMaps.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationMaps.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationImportTypeAliasInferredAndEmittable.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationImportTypeAliasInferredAndEmittable.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitWithInvalidPackageJsonTypings.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitWithInvalidPackageJsonTypings.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitUsingTypeAlias2.types | Baseline update for node_modules relative paths. |
| testdata/baselines/reference/submodule/compiler/declarationEmitUnnessesaryTypeReferenceNotAdded(target=es2015).types.diff | Baseline update for package specifier stabilization. |
| testdata/baselines/reference/submodule/compiler/declarationEmitUnnessesaryTypeReferenceNotAdded(target=es2015).types | Baseline update for package specifier stabilization. |
| testdata/baselines/reference/submodule/compiler/declarationEmitTransitiveImportOfHtmlDeclarationItem.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitTransitiveImportOfHtmlDeclarationItem.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitTopLevelNodeFromCrossFile2.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitTopLevelNodeFromCrossFile2.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitSymlinkPaths(target=es2015).types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitSymlinkPaths(target=es2015).types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitStringEnumUsedInNonlocalSpread.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitStringEnumUsedInNonlocalSpread.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitScopeConsistency.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitScopeConsistency.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReusesLambdaParameterNodes.types.diff | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReusesLambdaParameterNodes.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReexportedSymlinkReference3.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReexportedSymlinkReference3.types | Baseline update to keep package/paths stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReexportedSymlinkReference2.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReexportedSymlinkReference2.types | Baseline update to keep package/paths stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReexportedSymlinkReference.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReexportedSymlinkReference.types | Baseline update to keep package/paths stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReadonlyComputedProperty.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitReadonlyComputedProperty.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitQualifiedAliasTypeArgument.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitQualifiedAliasTypeArgument.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitNameConflicts.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitNameConflicts.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitImportInExportAssignmentModule.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitImportInExportAssignmentModule.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForTypesWhichNeedImportTypes.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForTypesWhichNeedImportTypes.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForModuleImportingModuleAugmentationRetainsImport.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForModuleImportingModuleAugmentationRetainsImport.types | Baseline update for augmentation import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForModuleImportingModuleAugmentationRetainsImport.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForModuleImportingModuleAugmentationRetainsImport.symbols | Baseline update for augmentation symbol naming. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForGlobalishSpecifierSymlink2.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForGlobalishSpecifierSymlink2.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForGlobalishSpecifierSymlink.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitForGlobalishSpecifierSymlink.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitExportAssignedNamespaceNoTripleSlashTypesReference.types.diff | Baseline diff update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitExportAssignedNamespaceNoTripleSlashTypesReference.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitExportAliasVisibiilityMarking.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitExportAliasVisibiilityMarking.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/declarationEmitDoesNotUseReexportedNamespaceAsLocal.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitDoesNotUseReexportedNamespaceAsLocal.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitDoesNotUseReexportedNamespaceAsLocal.symbols.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitDoesNotUseReexportedNamespaceAsLocal.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/declarationEmitCrossFileCopiedGeneratedImportType.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitCrossFileCopiedGeneratedImportType.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitCommonJsModuleReferencedType.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitCommonJsModuleReferencedType.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/declarationEmitAliasInlineing.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declarationEmitAliasFromIndirectFile.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/declarationEmitAliasFromIndirectFile.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declFileImportModuleWithExportAssignment.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declFileImportModuleWithExportAssignment.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declFileImportChainInExportAssignment.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/declFileImportChainInExportAssignment.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/constEnumPreserveEmitReexport.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/constEnumPreserveEmitReexport.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/constEnumNoPreserveDeclarationReexport.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/constEnumNoPreserveDeclarationReexport.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/constEnumNoEmitReexport.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/constEnumNoEmitReexport.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/conflictingDeclarationsImportFromNamespace2.types.diff | Baseline diff update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/conflictingDeclarationsImportFromNamespace2.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/conflictingDeclarationsImportFromNamespace1.types.diff | Baseline diff update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/conflictingDeclarationsImportFromNamespace1.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/commonjsAccessExports.types.diff | Baseline update for CommonJS exports typing/specifiers. |
| testdata/baselines/reference/submodule/compiler/commonjsAccessExports.types | Baseline update for CommonJS exports typing/specifiers. |
| testdata/baselines/reference/submodule/compiler/commonjsAccessExports.symbols.diff | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/commonjsAccessExports.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/commonJsUnusedLocals.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/commonJsUnusedLocals.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/commonJsUnusedLocals.symbols.diff | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/commonJsUnusedLocals.symbols | Baseline update for symbol naming. |
| testdata/baselines/reference/submodule/compiler/commonJsIsolatedModules.symbols.diff | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/commonJsIsolatedModules.symbols | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/commonJsExportTypeDeclarationError(target=es2015).symbols.diff | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/commonJsExportTypeDeclarationError(target=es2015).symbols | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/checkerInitializationCrash.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/checkerInitializationCrash.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/checkMergedGlobalUMDSymbol.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/checkMergedGlobalUMDSymbol.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/checkJsdocTypeTagOnExportAssignment6.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/checkJsdocTypeTagOnExportAssignment6.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/checkJsdocTypeTagOnExportAssignment5.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/checkJsdocTypeTagOnExportAssignment5.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/checkJsdocTypeTagOnExportAssignment2.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/checkJsdocTypeTagOnExportAssignment2.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/checkJsdocTypeTagOnExportAssignment1.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/checkJsdocTypeTagOnExportAssignment1.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/checkJsTypeDefNoUnusedLocalMarked.symbols.diff | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/checkJsTypeDefNoUnusedLocalMarked.symbols | Baseline update for module symbol naming. |
| testdata/baselines/reference/submodule/compiler/augmentExportEquals6.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/augmentExportEquals6.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/augmentExportEquals5.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/augmentExportEquals5.types | Baseline update to keep package specifiers stable. |
| testdata/baselines/reference/submodule/compiler/augmentExportEquals4.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/augmentExportEquals4.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/augmentExportEquals3.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/augmentExportEquals3.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/anonClassDeclarationEmitIsAnon.types.diff | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/anonClassDeclarationEmitIsAnon.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/ambientExportDefaultErrors.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/ambientExportDefaultErrors.types | Baseline update for relative import specifiers. |
| testdata/baselines/reference/submodule/compiler/allowSyntheticDefaultImportsCanPaintCrossModuleDeclaration.types.diff | Baseline diff removal/update due to specifier changes. |
| testdata/baselines/reference/submodule/compiler/allowSyntheticDefaultImportsCanPaintCrossModuleDeclaration.types | Baseline update for relative import specifiers. |
| "github.com/microsoft/typescript-go/internal/modulespecifiers" | ||
| ) | ||
|
|
||
| // TODO: previously all symboltracker methods were optional, but now they're required. |
There was a problem hiding this comment.
The TODO comment is now misleading: this interface no longer includes the (previously required) module-specifier host method, and the change in this PR makes the host come from NodeBuilderContext instead. Update or remove this comment so it reflects the current design (host is always provided by NodeBuilder rather than via the tracker).
Suggested change
| // TODO: previously all symboltracker methods were optional, but now they're required. | |
| // SymbolTracker provides callbacks used by the node builder; all methods are required, and any | |
| // host or module-specifier context is supplied via NodeBuilderContext rather than this interface. |
Member
Author
There was a problem hiding this comment.
I honestly don't know how this suggestion is an improvement
DanielRosenwasser
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matching microsoft/TypeScript#62726.