Multiproject requests like find all refs, rename and workspace symbols #1991

sheetalkamat · 2025-10-31T16:52:45Z

No description provided.

Also remove unnecessary program update when doing gc on projects

… tree

… with -v so we can diagnose which test is failing

internal/lsp/lspservertests/testserver.go

Copilot

Pull Request Overview

This PR updates test baselines to reflect improved formatting and line numbering consistency in the test output files. The changes normalize how JSON content and TypeScript code are displayed in baseline files, removing inconsistent indentation and adding proper line numbers to all content.

Key Changes

Standardized line numbering for all file content in test baselines
Normalized JSON formatting to use consistent indentation (4 spaces)
Fixed indentation for TypeScript code blocks in test files
Updated hash values in tsbuildinfo files to reflect the normalized content

Reviewed Changes

Copilot reviewed 100 out of 125 changed files in this pull request and generated 62 comments.

Show a summary per file

File	Description
tsc/moduleResolution/alternateResult.js	Added line numbers to JSON package files and normalized their indentation
tsc/declarationEmit/when-using-Windows-paths-and-uppercase-letters.js	Standardized indentation for TypeScript source code and adjusted error column positions
tsbuildWatch/projectsBuilding/*.js	Normalized tsconfig.json indentation across multiple project building tests
tsbuildWatch/programUpdates/*.js	Updated file content formatting and corresponding hash values in tsbuildinfo
tsbuild/resolveJsonModule/*.js	Consistent JSON formatting for all tsconfig.json files
lspservertests/rename/*.js	Added complete baseline content for new rename test cases
lspservertests/findAllRefs/*.js	Added complete baseline content for new find all references test cases

internal/testutil/lsptestutil/baseline.go

...s/reference/lspservertests/declarationMaps/findAllReferences-definition-is-in-mapped-file.js

...selines/reference/lspservertests/declarationMaps/findAllReferences-starting-at-definition.js

...aselines/reference/lspservertests/declarationMaps/findAllReferences-target-does-not-exist.js

...rvertests/findAllRefs/special-handling-of-localness-when-using-method-of-class-expression.js

...ervertests/findAllRefs/special-handling-of-localness-when-using-arrow-function-assignment.js

...pservertests/findAllRefs/special-handling-of-localness-when-using-object-literal-property.js

testdata/baselines/reference/lspservertests/rename/rename-in-common-file-renames-all-project.js

testdata/baselines/reference/lspservertests/rename/ancestor-and-project-ref-management.js

jakebailey

Some comments; have not read the entire thing yet.

internal/lsp/lsproto/_generate/generate.mts

internal/sourcemap/lineinfo.go

internal/lsp/lspservertests/testserver.go

internal/lsp/server.go

internal/testutil/lsptestutil/lsptestutil.go

internal/testutil/lsptestutil/baseline.go

internal/compiler/projectreferencefilemapper.go

internal/project/configfileregistry.go

internal/project/session.go

internal/project/snapshot.go

sheetalkamat · 2025-11-14T00:12:50Z

converting tests to fourslash uncovered some more ordering issues with results. Looking into that as well as handling the feedback

andrewbranch

All my concerns are addressed, hopefully someone else can review as well 👍

jakebailey · 2025-11-14T21:43:05Z

I'll give it another pass shortly, though I was waiting until it was mostly passing CI.

jakebailey · 2025-11-14T22:54:21Z

internal/fourslash/_scripts/updateFailing.mts

    let testOutput: string;
    try {
-        testOutput = cp.execFileSync(go, ["test", "./internal/fourslash/tests/gen"], { encoding: "utf-8" });
+        testOutput = cp.execFileSync(go, ["test", "-v", "./internal/fourslash/tests/gen"], { encoding: "utf-8" });


Does this end up printing a lot?

This is when it panics we can diagnose the issue rather than having to manually run those steps and tests again to figure out which test had panic that was not expected. (eg i got one when i was not associating reqID for panics when operating on projects inside those go routines.)

sheetalkamat · 2025-11-15T00:24:41Z

All my concerns are addressed, hopefully someone else can review as well 👍

I am still looking into deduplicating results as there is still something going on there.

sheetalkamat force-pushed the multiProject branch 5 times, most recently from 46a8abe to f66df9c Compare November 3, 2025 20:32

sheetalkamat added 20 commits November 3, 2025 13:43

Factor out lsp server setup so we can use it for some unit testing

9e6e021

Add some tests that can verify the server multi project things

b7dc8db

Rename tests

28dd671

Declaration map tests

1171089

factor out todos

9516c6f

Handle existing projects

f88b8f2

Framework to queue more locations

4f25a86

Use declaration maps to queue more projects

5d230c1

Actually find and load the original location projects

fcfedab

navigate to source when we can when reporting references

5470a9d

Create ancestor tree

12c0e93

Actually load ancestor project tree

64a2d44

Fix the order of the results and deduplication

812c9bc

Retain ancestor projects and references till open file is present

fee7f97

Also remove unnecessary program update when doing gc on projects

Fix the config lifetime when getting project for non open file

70ca6da

Parallel

23f8f3f

Port special localness checks to determine if we need to load project…

2be521c

… tree

Baseline workspace symbols

0f005e7

Workspace symbols to load more projects

3a76f2a

Show output of panic found when updating fourslash tests and run them…

72e09da

… with -v so we can diagnose which test is failing

sheetalkamat force-pushed the multiProject branch from 97ecb11 to 72e09da Compare November 3, 2025 21:49

sheetalkamat marked this pull request as ready for review November 4, 2025 20:00

Copilot AI review requested due to automatic review settings November 4, 2025 20:00

sheetalkamat commented Nov 4, 2025

View reviewed changes

internal/lsp/lspservertests/testserver.go Outdated Show resolved Hide resolved

Merge branch 'main' into multiProject

e2c372c

sheetalkamat requested review from andrewbranch and jakebailey November 4, 2025 20:07

Copilot AI reviewed Nov 4, 2025

View reviewed changes

jakebailey reviewed Nov 5, 2025

View reviewed changes

sheetalkamat added 3 commits November 7, 2025 16:06

Merge branch 'main' into multiProject

e9a71c4

Feedback

7b6c01d

Merge branch 'main' into multiProject

344f432

sheetalkamat requested a review from jakebailey November 10, 2025 19:39

Refactor

6727c37

sheetalkamat mentioned this pull request Nov 11, 2025

Add locks on concurrent alias following checker accesses under incremental mode #2051

Merged

andrewbranch reviewed Nov 11, 2025

View reviewed changes

sheetalkamat added 5 commits November 11, 2025 10:45

Merge branch 'main' into multiProject

f037f5d

Move tests to fourslash

a8a2af6

Remove lspservertests folder

8cf43c8

Move the functionality of pulled out server back into the fourslash

366e922

Merge branch 'main' into multiProject

6281763

sheetalkamat added 5 commits November 13, 2025 16:30

Handle scriptInfos that get created as part of symlink

c2cd31c

Change forEach to range

b89cd8c

Remove unnecessary method

53e79d8

Remove ForEachProjectLocationLoadingProjectTree

d19996e

refator snapshot request and how snapshot is queried for resources

a661a3d

andrewbranch approved these changes Nov 14, 2025

View reviewed changes

jakebailey mentioned this pull request Nov 14, 2025

Fully resolve LSP client caps to non-pointers, pass by context #2095

Merged

jakebailey reviewed Nov 14, 2025

View reviewed changes

Multiproject requests like find all refs, rename and workspace symbols #1991

Are you sure you want to change the base?

Multiproject requests like find all refs, rename and workspace symbols #1991

Uh oh!

Conversation

sheetalkamat commented Oct 31, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sheetalkamat commented Nov 14, 2025

Uh oh!

andrewbranch left a comment

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Nov 14, 2025

Uh oh!

jakebailey Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

sheetalkamat Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

sheetalkamat commented Nov 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants