Fixed a class member completion crash after JSDoc comment with degenerate JSDoc tag in it#2888
Open
Andarist wants to merge 12 commits intomicrosoft:mainfrom
Open
Fixed a class member completion crash after JSDoc comment with degenerate JSDoc tag in it#2888Andarist wants to merge 12 commits intomicrosoft:mainfrom
Andarist wants to merge 12 commits intomicrosoft:mainfrom
Conversation
…rate JSDoc tag in it
Andarist
commented
Feb 24, 2026
Andarist
commented
Feb 24, 2026
internal/fourslash/tests/completionsAtTopLevelImportAssignmentNoCrash1_test.go
Show resolved
Hide resolved
gabritto
requested changes
Feb 24, 2026
Member
gabritto
left a comment
gabritto
left a comment
There was a problem hiding this comment.
(see comment on fixing the tag parsing)
…member-at-rule-crash
…member-at-rule-crash
Member
|
(I'm looking into the race mode test failure; seems like a flaky test not related to this PR) |
sandersn
reviewed
Feb 27, 2026
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
I think this is the right approach. One question about a possible efficiency improvement.
internal/scanner/scanner.go
Outdated
| saved := s.Mark() | ||
| s.pos += size | ||
| s.ScanJSDocToken() | ||
| isIdentifier := tokenIsIdentifierOrKeyword(s.token) |
Member
There was a problem hiding this comment.
is there a definition of what an identifier or keyword starts with so we don't have to scan a whole jsdoc token? My instinct is to avoid backtracking.
this may be a non-issue in the Corsa scanner; I can't remember how expensive Mark/Rewind+ScanJSDocToken are, and @ is not a common character in jsdoc in any case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the crash reported here: #2871 (comment)
it also crashes in Strada