[WIP] Port changes from TypeScript pull request 63200#2930
Draft
[WIP] Port changes from TypeScript pull request 63200#2930
Conversation
- Add new TS2883 diagnostic with symbol name in error message - Keep TS2742 unchanged for backward compatibility - Update SymbolTracker interface to pass symbolName parameter - Update all implementations (symboltracker.go, nodebuilderimpl.go, tracker.go) - Add declarationEmitUnsafeImportSymbolName test case - Accept updated baselines Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
jakebailey
reviewed
Feb 27, 2026
| // since declaration files with these kinds of references are liable to fail when published :( | ||
| b.ctx.encounteredError = true | ||
| b.ctx.tracker.ReportLikelyUnsafeImportRequiredError(oldSpecifier) | ||
| b.ctx.tracker.ReportLikelyUnsafeImportRequiredError(oldSpecifier, symbol.Name) |
Member
There was a problem hiding this comment.
Can't symbol be nil like the original PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SymbolTrackerinterface: addsymbolName stringparameter toReportLikelyUnsafeImportRequiredErrorSymbolTrackerImplinchecker/symboltracker.go: forwardsymbolNamenodebuilderimpl.go: passsymbol.Nameas symbolNamedeclarations/tracker.go: use TS2883 when symbolName provided, fallback to TS2742 otherwisedeclarationEmitUnsafeImportSymbolName.ts💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.