Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes emit flags that are unused or have become no-ops in this TypeScript compiler/LS Go port, simplifying emit/transform logic and reducing dead code paths.
Changes:
- Removed
EFNeverApplyImportHelperand deleted now-dead conditional logic in the CommonJS module transformer. - Removed
EFInternalNameandEFNoHoistingemit flags and cleaned up remaining call sites/comments. - Simplified external helpers import emit-flagging to only apply
EFCustomPrologue.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/transformers/moduletransforms/externalmoduleinfo.go | Stops applying removed EFNeverApplyImportHelper to synthetic external-helpers imports. |
| internal/transformers/moduletransforms/commonjsmodule.go | Deletes dead branches that checked EFNeverApplyImportHelper and simplifies default-export handling. |
| internal/transformers/estransforms/using.go | Removes masking of the deleted EFInternalName flag when cloning identifiers. |
| internal/transformers/estransforms/forawait.go | Removes application of the deleted EFNoHoisting flag. |
| internal/printer/emitflags.go | Removes the unused/no-op emit flags from the canonical definition list. |
| internal/compiler/fileloader.go | Deletes stale commented-out code referencing removed internal emit-flag behavior. |
| internal/checker/nodebuilderimpl.go | Marks synthesized property-access expressions with EFNoIndentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flags are either unused, or do nothing due to us dropping ES5 or restructuring faked imports.