Fix @scope parsing to support selector lists#474
Open
Arecsu wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix @scope parsing to support selector lists#474Arecsu wants to merge 1 commit intomicrosoft:mainfrom
@scope parsing to support selector lists#474Arecsu wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree company="MARTYR X LTD" |
Arecsu
force-pushed
the
fix/scope-selector-list
branch
from
81173ac to
c5c2b42
Compare
Arecsu
changed the title
@scope parsing to support selector lists
The `@scope` rule parser only accepted a single selector inside the
parentheses, causing a false `) expected` error when using
comma-separated selector lists like `@scope (.foo, .bar) { }`.
This is valid CSS per the CSS Cascading and Inheritance Level 6
specification, which defines scope-start and scope-end as
<selector-list>.
Extract a _parseScopeSelectorList() helper that handles
comma-separated selectors, matching the existing pattern used
in _parsePseudo() for pseudo-class selector lists.
Fixes microsoft/vscode#290942
Arecsu
force-pushed
the
fix/scope-selector-list
branch
from
c5c2b42 to
6ebfeaa
Compare
ej-shafran
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The @scope rule parser only accepted a single selector inside the parentheses, causing a false
) expectederror when using comma-separated selector lists like@scope (.foo, .bar) { }.Extract a _parseScopeSelectorList() helper that handles comma-separated selectors, matching the existing pattern used in _parsePseudo() for pseudo-class selector lists.
Fixes microsoft/vscode#290942