Revert "[typescript-language-features] Expandable hover (#228255)"#240011
Merged
mjbvz merged 5 commits intomicrosoft:mainfrom Feb 26, 2025
Merged
Revert "[typescript-language-features] Expandable hover (#228255)"#240011mjbvz merged 5 commits intomicrosoft:mainfrom
mjbvz merged 5 commits intomicrosoft:mainfrom
Conversation
mjbvz
previously approved these changes
Feb 7, 2025
roblourens
reviewed
Feb 7, 2025
roblourens
previously approved these changes
Feb 7, 2025
joshspicer
previously approved these changes
Feb 8, 2025
mjbvz
approved these changes
Feb 26, 2025
amunger
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0f9abf3.
We removed the expandable hover prototype from TSServer ahead of the TS 5.8 RC: microsoft/TypeScript#61132.
I thought it best to revert it for now, and add this back later to vscode when we get the full feature into TSServer, because we won't get the feature back in time in TSServer for the 5.9 nightlies (see: microsoft/TypeScript#61132 (comment))