Setting and removing window.activeBorder color does not reset the window border color (fix #264569)
#277359
+5
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… window border color (fix #264569)
Copilot finished reviewing on behalf of
bpasero
November 14, 2025 08:31
bpasero
changed the title
window.activeBorder color does not reset the window border color (fix #264569)window.activeBorder color does not reset the window border color (fix #264569)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #264569 where setting and removing the window.activeBorder color does not properly reset the window border color. The fix involves two key changes: removing the window.border setting from the list of settings that require a window restart (allowing dynamic updates), and correcting the logic for resetting to default accent colors by using null instead of an empty string.
- Removed
window.borderfrom settings requiring restart, enabling dynamic updates - Fixed default accent color reset logic to use
nullinstead of empty string
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts | Removed window.border from restart-required settings and cleaned up unused isWindows import |
| src/vs/platform/native/electron-main/nativeHostMainService.ts | Changed default accent color reset from empty string to null to properly match Electron API expectations |
lszomoru
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Electron 39.2.0
//cc @deepak1556