Skip to content

Add test for BOM character preservation in VSBuffer (issue #251527) #277608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2025
+14 −0
Merged

Add test for BOM character preservation in VSBuffer (issue #251527) #277608

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68c8d12
Initial plan
Copilot Nov 15, 2025
6608216
Add test for issue #251527 - BOM character preservation in VSBuffer
Copilot Nov 15, 2025
6d8ced6
Update src/vs/base/test/common/buffer.test.ts
bpasero Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/vs/base/test/common/buffer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,20 @@ suite('Buffer', () => {
assert.deepStrictEqual(buffer.toString(), 'hi');
});

test('issue #251527 - VSBuffer#toString preserves BOM character in filenames', () => {
// BOM character (U+FEFF) is a zero-width character that was being stripped
// when deserializing messages in the IPC layer. This test verifies that
// the BOM character is preserved when using VSBuffer.toString().
const bomChar = '\uFEFF';
const filename = `${bomChar}c.txt`;
const buffer = VSBuffer.fromString(filename);
const result = buffer.toString();

// Verify the BOM character is preserved
assert.strictEqual(result, filename);
assert.strictEqual(result.charCodeAt(0), 0xFEFF);
});

test('bufferToReadable / readableToBuffer', () => {
const content = 'Hello World';
const readable = bufferToReadable(VSBuffer.fromString(content));
Expand Down
Loading