Added support for optional Authorization and Accept headers via environment variables.#634
Open
azchohfi wants to merge 1 commit intomicrosoft:mainfrom
Open
Added support for optional Authorization and Accept headers via environment variables.#634azchohfi wants to merge 1 commit intomicrosoft:mainfrom
azchohfi wants to merge 1 commit intomicrosoft:mainfrom
Conversation
headers via environment variables, improving flexibility.
Contributor
|
I'm not sure I understand the use case here. The manifests submitted to microsoft/winget-pkgs require that the URL is publicly available. If the InstallerUrl is under a private repo which needs an auth header, the manifest would not pass the validation pipelines at winget-pkgs, which means you will have to make the repo public anyway. Is the intent to submit the wingetcreate generated manifest to a private GitHub repository other than microsoft/winget-pkgs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #633.
This allows me to call:
Then provide an url such as: https://api.github.com/repos/myorg/privaterepo/releases/assets/ID
Microsoft Reviewers: Open in CodeFlow