-
Notifications
You must be signed in to change notification settings - Fork 75
chore: kiota is downloaded instead of built during generation #1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ramsessanchez
wants to merge
8
commits into
main
Choose a base branch
from
chore/kiota-download-in-generation-pipeline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−31
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1c28afd
chore: kiota is now downloaded from nuget rather than built locally d…
ramsessanchez 3eef546
download binaries from github releases
ramsessanchez 009eca4
get kiota binary download link
ramsessanchez 3fa9fce
extract kiota to correct directory
ramsessanchez 7732682
swith to pwsh
ramsessanchez 8b3417c
revert to bash, ensure correct extraction path
ramsessanchez 49c19f6
revert to bash
ramsessanchez 7e8aaa5
make kiota exe path resillient
ramsessanchez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 18 additions & 17 deletions
35
.azure-pipelines/generation-templates/build-and-publish-kiota.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,19 @@ | ||
| steps: | ||
| - template: /.azure-pipelines/generation-templates/use-dotnet-sdk.yml@self | ||
| parameters: | ||
| version: "10.x" #kiota uses a net10 target | ||
|
|
||
| - checkout: kiota | ||
| displayName: checkout kiota | ||
| fetchDepth: 1 | ||
|
|
||
| - pwsh: dotnet build $(Build.SourcesDirectory)/src/kiota/kiota.csproj --configuration $(buildConfiguration) | ||
| displayName: 'Build Kiota' | ||
|
|
||
| - task: CopyFiles@2 | ||
| inputs: | ||
| sourceFolder: '$(Build.SourcesDirectory)/src/kiota/bin/$(BuildConfiguration)/net10.0' | ||
| contents: '**/*' | ||
| targetFolder: '$(Build.ArtifactStagingDirectory)' | ||
| displayName: Copy Kiota executable | ||
| - bash: | | ||
| RELEASE_JSON=$(curl -s "https://api.github.com/repos/microsoft/kiota/releases/latest") | ||
| LATEST_TAG=$(echo "$RELEASE_JSON" | jq -r '.tag_name') | ||
| ASSET_URL=$(echo "$RELEASE_JSON" | jq -r '.assets[] | select(.name | test("linux-x64")) | .browser_download_url') | ||
| echo "Downloading Kiota $LATEST_TAG" | ||
| echo "Asset URL: $ASSET_URL" | ||
| curl -L "$ASSET_URL" -o kiota_download | ||
| mkdir -p /tmp/kiota_extract | ||
| if [[ "$ASSET_URL" == *.zip ]]; then | ||
| unzip kiota_download -d /tmp/kiota_extract | ||
| else | ||
| tar -xzf kiota_download -C /tmp/kiota_extract | ||
| fi | ||
| KIOTA_BIN=$(find /tmp/kiota_extract -name kiota -type f | head -1) | ||
| echo "Found Kiota binary at: $KIOTA_BIN" | ||
| mkdir -p "$(Build.ArtifactStagingDirectory)" | ||
| cp "$KIOTA_BIN" "$(Build.ArtifactStagingDirectory)/kiota" | ||
| displayName: 'Download latest Kiota from GitHub' |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule vipr
updated
3 files
| +1 −1 | .github/CODEOWNERS | |
| +1 −1 | .github/workflows/dotnet.yml | |
| +8 −54 | src/Readers/Vipr.Reader.OData.v4/OdcmReader.cs |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we downloading from the github releases rather than installing the dotnet tool?
Also we need to use actual script for multi-line scripts not inline.