Skip to content

Conversation

@rsporny
Copy link
Contributor

@rsporny rsporny commented Dec 15, 2025

Overview

Added:

  • added test to verify RegularTx and SystemTx in the same block doesn't break the chain or indexer
  • added socat container to local-env to allow cardano-cli usage between host<->container

Changed:

  • e2e tests that rely on one-shot-utxo are behind a feature flag and executed by default in CI
  • e2e tests default env is set to local from local-ci

Refs: PM-20886

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@rsporny rsporny requested a review from a team as a code owner December 15, 2025 13:40
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Logo
Checkmarx One – Scan Summary & Details7b68c420-79cc-4d24-a086-47394980a1f0

New Issues (41)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 282
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: GD3ZL2vaOuiLN%2FkBCnIgwVmQhvc%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 202
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: pLklumsPKeDPatzZ0jmB8%2B0AmQI%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 142
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: FphX4uSiUrBXsX1Gnh%2BRuDDaGzk%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 108
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: 2okSJZQONBH%2FjrgjEcS5Xlopkk0%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 170
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: ofQy2F6Y6hM7MuQE0Vz6vHpYP6Y%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 365
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: romy5roQcOVKFM2QpTkoBAzT9U4%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 55
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: rSi8%2Fkb3si4oJRa5apDGuI8f2ss%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 399
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: MBD1f1vqgwt%2FCmKO5hE%2Ft8X9T6o%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 435
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: b%2FDbTNujn9eV%2F2PHIJO50rI1Yg4%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 231
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: f6cRFkrHh75EUmB5BiOrZcIAIKI%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 331
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: DuLRLRlrFisTqqyllQDpOyWU680%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 77
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: 3eaNk%2BYY2ET7KxAE%2FXgic8CeIXE%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 262
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: %2B%2BL6uTgn1ukQerY1ViWv0nBwQDw%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 296
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: NgrGEk0E9oLF3n1eKgjBssivFdU%3D
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 471
detailsSome capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec...
ID: DqydU1H%2BZ9WgyVw0rYzyJbKCMrk%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 74
detailsIncoming container traffic should be bound to a specific host interface
ID: c85a5r0aMHTE55ZQysvEN37%2FgnA%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 181
detailsIncoming container traffic should be bound to a specific host interface
ID: UNU7JPaBUy1wTJ9l8duu8RXOYos%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 460
detailsIncoming container traffic should be bound to a specific host interface
ID: B6UGmJW6XLsV%2Bm5nmowXRpAiqbU%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 319
detailsIncoming container traffic should be bound to a specific host interface
ID: oxGEhEZ2cbMZ0DTS5592LADuvLs%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 388
detailsIncoming container traffic should be bound to a specific host interface
ID: KC8q%2BeK9VZ0oa0v9ihvztWSDu5Q%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 242
detailsIncoming container traffic should be bound to a specific host interface
ID: ysxg%2B9sW3Vn7SDgdNEE2WvIMu0k%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 52
detailsIncoming container traffic should be bound to a specific host interface
ID: tvas3Zga5umpVjJOB7z0LxhEogM%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 354
detailsIncoming container traffic should be bound to a specific host interface
ID: ffvNxcSiKJbWk2D0Gjh1l%2Fh8a1c%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 289
detailsIncoming container traffic should be bound to a specific host interface
ID: C1JG7bvbWMDD56KxCwUOvwwdiUA%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 159
detailsIncoming container traffic should be bound to a specific host interface
ID: 72mF2nLCrs%2FiUbx%2BnOVDlrfB5kI%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 98
detailsIncoming container traffic should be bound to a specific host interface
ID: 88dSUUHfp3MdkEbG56Uv0SZUU%2FU%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 213
detailsIncoming container traffic should be bound to a specific host interface
ID: rckE2LoWkEd6xNbEoLq1co0wsdg%3D
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 424
detailsIncoming container traffic should be bound to a specific host interface
ID: nDYiPr8b%2FetzS9Zat29lJJRzGbQ%3D
MEDIUM Healthcheck Not Set /docker-compose.yml: 296
detailsCheck containers periodically to see if they are running properly.
ID: IsfmLSXxx7x5qtFYZfrVZZ%2F0VOU%3D
MEDIUM Healthcheck Not Set /docker-compose.yml: 55
detailsCheck containers periodically to see if they are running properly.
ID: 0gklDxs%2BJ9FQ1QSF8%2BANWXBebqU%3D
MEDIUM Healthcheck Not Set /docker-compose.yml: 282
detailsCheck containers periodically to see if they are running properly.
ID: UoI1pdjbFKrpBNYtSxocYdWQwaY%3D
MEDIUM Healthcheck Not Set /docker-compose.yml: 108
detailsCheck containers periodically to see if they are running properly.
ID: o6BRrc%2BVOQfrZZSk6UzomBnnqLo%3D
MEDIUM Healthcheck Not Set /docker-compose.yml: 331
detailsCheck containers periodically to see if they are running properly.
ID: haskxYHEQb50KOlubtURVh4pJnU%3D
MEDIUM Healthcheck Not Set /docker-compose.yml: 435
detailsCheck containers periodically to see if they are running properly.
ID: pGIFh0%2BZzTWAAhNkMgXeKs1F%2B6I%3D
MEDIUM Healthcheck Not Set /docker-compose.yml: 365
detailsCheck containers periodically to see if they are running properly.
ID: uMf0Kjb0LYt1%2B48s6FhDT0czcL8%3D
MEDIUM Healthcheck Not Set /docker-compose.yml: 471
detailsCheck containers periodically to see if they are running properly.
ID: 50LQDMli5H2VgL1FEsosQI7Xmrc%3D
MEDIUM Healthcheck Not Set /docker-compose.yml: 399
detailsCheck containers periodically to see if they are running properly.
ID: HUB6bjqFeY%2FwsAuLGXmdcOzKdEk%3D
MEDIUM Security Opt Not Set /docker-compose.yml: 55
detailsAttribute 'security_opt' should be defined.
ID: uAflSYeSBNYDVFg%2BVlN2aRaYnoo%3D
MEDIUM Security Opt Not Set /docker-compose.yml: 202
detailsAttribute 'security_opt' should be defined.
ID: rQULPjUjTkbcPl%2Bqjd1NP9TW%2FfE%3D
MEDIUM Security Opt Not Set /docker-compose.yml: 231
detailsAttribute 'security_opt' should be defined.
ID: XHfs69ILo53RDXhAjqRVEiYV4LI%3D
MEDIUM Security Opt Not Set /docker-compose.yml: 170
detailsAttribute 'security_opt' should be defined.
ID: %2FVc9MTlMFnlbcgQIoAZTCEcxlUA%3D
Fixed Issues (35)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 418
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 245
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 159
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 66
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 348
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 265
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 279
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 214
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 131
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 454
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 188
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 314
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 382
MEDIUM Container Capabilities Unrestricted /docker-compose.yml: 97
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 407
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 225
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 63
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 87
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 337
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 302
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 443
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 371
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 272
MEDIUM Container Traffic Not Bound To Host Interface /docker-compose.yml: 148
MEDIUM Healthcheck Not Set /docker-compose.yml: 265
MEDIUM Healthcheck Not Set /docker-compose.yml: 418
MEDIUM Healthcheck Not Set /docker-compose.yml: 314
MEDIUM Healthcheck Not Set /docker-compose.yml: 279
MEDIUM Healthcheck Not Set /docker-compose.yml: 382
MEDIUM Healthcheck Not Set /docker-compose.yml: 454
MEDIUM Healthcheck Not Set /docker-compose.yml: 348
MEDIUM Healthcheck Not Set /docker-compose.yml: 97
MEDIUM Security Opt Not Set /docker-compose.yml: 188
MEDIUM Security Opt Not Set /docker-compose.yml: 214
MEDIUM Security Opt Not Set /docker-compose.yml: 159

ports:
- "32000:32000"

cardano-node-socat:

Check warning

Code scanning / Checkmarx One

Container Capabilities Unrestricted Medium

Container Capabilities Unrestricted
ports:
- "32000:32000"

cardano-node-socat:

Check warning

Code scanning / Checkmarx One

Healthcheck Not Set Medium

Healthcheck Not Set
ports:
- "32000:32000"

cardano-node-socat:

Check warning

Code scanning / Checkmarx One

Security Opt Not Set Medium

Security Opt Not Set
- cardano-node-1
volumes:
- cardano-node-1-data:/data
ports:

Check warning

Code scanning / Checkmarx One

Container Traffic Not Bound To Host Interface Medium

Container Traffic Not Bound To Host Interface
condition: "service_started"
image: ${INDEXER_CHAIN_IMAGE}
restart: "no"
ports:

Check warning

Code scanning / Checkmarx One

Container Traffic Not Bound To Host Interface Medium

Container Traffic Not Bound To Host Interface
condition: "service_started"
image: ${INDEXER_WALLET_IMAGE}
restart: "no"
ports:

Check warning

Code scanning / Checkmarx One

Container Traffic Not Bound To Host Interface Medium

Container Traffic Not Bound To Host Interface
@rsporny rsporny force-pushed the e2e-block-8226-invalid-proof branch 3 times, most recently from 16ff51a to 197415d Compare December 16, 2025 08:14
@rsporny
Copy link
Contributor Author

rsporny commented Dec 16, 2025

/bot rebuild-metadata

@rsporny rsporny force-pushed the e2e-block-8226-invalid-proof branch from 197415d to 8d31a7b Compare December 16, 2025 13:28
@github-actions
Copy link
Contributor

✅ Metadata rebuild complete. No changes detected.

added:
- e2e test that generates regularTx and systemTx in one block
- socat container to allow `cardano-cli` usage between host and
container

changed:
- e2e tests that rely on one-shot-utxo are behind a feature flag and
executed by default in CI
- e2e tests default env is set to local from local-ci

Refs: PM-20886
@rsporny rsporny force-pushed the e2e-block-8226-invalid-proof branch from 9ce80a0 to 234d915 Compare December 17, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants