-
Notifications
You must be signed in to change notification settings - Fork 15
CI: switch to scan action #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
2 similar comments
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
cargo-deny produces SARIF with snippet/message fields as strings,
but the SARIF spec requires them to be objects with a text property.
This causes GitHub to reject the upload.
Add jq post-processing step to transform string values into proper
{"text": "value"} objects before upload.
GitHub's CodeQL upload-sarif action requires each SARIF file to have a unique category when uploading multiple files. Split the single batch upload into separate uploads with distinct categories: - cargo-deny - npm-audit-local-environment - npm-audit-toolkit-js - npm-audit-ui-tests - npm-audit-ui
chrisferry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lgtm
cosmir17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This replaces the closed source checkmarx scan action with one using a composite of open source scanners. It should run without issues on contributers PRs.
Uses midnightntwrk/upload-sarif-github-action#43