Skip to content

Conversation

@gilescope
Copy link
Contributor

@gilescope gilescope commented Dec 16, 2025

This replaces the closed source checkmarx scan action with one using a composite of open source scanners. It should run without issues on contributers PRs.

Uses midnightntwrk/upload-sarif-github-action#43

@gilescope gilescope requested review from a team as code owners December 16, 2025 10:00
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

2 similar comments
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@gilescope gilescope enabled auto-merge (squash) December 27, 2025 08:32
cargo-deny produces SARIF with snippet/message fields as strings,
but the SARIF spec requires them to be objects with a text property.
This causes GitHub to reject the upload.

Add jq post-processing step to transform string values into proper
{"text": "value"} objects before upload.
GitHub's CodeQL upload-sarif action requires each SARIF file to have
a unique category when uploading multiple files. Split the single
batch upload into separate uploads with distinct categories:
- cargo-deny
- npm-audit-local-environment
- npm-audit-toolkit-js
- npm-audit-ui-tests
- npm-audit-ui
Copy link
Contributor

@chrisferry chrisferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

Copy link
Contributor

@cosmir17 cosmir17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gilescope gilescope merged commit 660e5dc into main Dec 29, 2025
35 checks passed
@gilescope gilescope deleted the giles-decheckmarx branch December 29, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants