rotation can be not only in the first element of side_data_list#264
Open
smka wants to merge 1 commit intomifi:masterfrom
Open
rotation can be not only in the first element of side_data_list#264smka wants to merge 1 commit intomifi:masterfrom
smka wants to merge 1 commit intomifi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!

I've found that rotation on vertical HDR videos from my phone defined incorrectly. All videos without HDR don't have this issue.
My setup:
ffprobe shows that HDR videos have several elements in side_data_list
{ "side_data_list":[ { "side_data_type":"DOVI configuration record", "dv_version_major":1, "dv_version_minor":0, "dv_profile":8, "dv_level":5, "rpu_present_flag":1, "el_present_flag":0, "bl_present_flag":1, "dv_bl_signal_compatibility_id":4 }, { "side_data_type":"Display Matrix", "displaymatrix":"\n00000000: 0 65536 0\n00000001: -65536 0 0\n00000002: 70778880 0 1073741824\n", "rotation":-90 } ] }So I replaced this with foreach cycle.
PS. But I still don't understand why parseInt(stream.tags && stream.tags.rotate, 10) always return NaN, when data is present in ffprobe json.