chore: clean up ffmpeg/ffprobe config, update to execa@8#313
Merged
chore: clean up ffmpeg/ffprobe config, update to execa@8#313
Conversation
bkeepers
force-pushed
the
ffmpeg-config
branch
from
2772134 to
cb80fb2
Compare
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
bkeepers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactoring to configure ffmpeg/ffprobe once when editly is loaded and not have to pass around the params everywhere. This also exposes
ffmpegandffprobefunctions to centralize whereexecais being called so I can work on #304 without having to update multiple callsites.