Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @maamokun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Japanese localization file ( Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, titled 'New Crowdin updates', modifies the Japanese localization file src/messages/ja.json. My review found a critical issue: many of the new and updated translation strings are in English instead of Japanese. This appears to be an error from the localization process, possibly with Crowdin, where source English strings were committed instead of their Japanese translations. This will result in a broken experience for Japanese users, as much of the UI will be in English. I've left specific comments pointing out the sections with incorrect translations.
| "layout": { | ||
| "resources": "Resources", | ||
| "solutions": "Solutions", | ||
| "accountCenter": "Account Center", | ||
| "support": "Support", | ||
| "contact": "Contact Us", | ||
| "legal": "Legal", | ||
| "terms": "Terms of Service", | ||
| "privacy": "Privacy Policy", | ||
| "refunds": "Refund Policy", | ||
| "jp-payments": "特定商取引法に基づく表記", | ||
| "home": "Home", | ||
| "vision": "Our Vision", | ||
| "opensource": "Open Source" | ||
| }, |
There was a problem hiding this comment.
Most translation values in this layout section are in English. As this is the Japanese localization file (ja.json), these values should be in Japanese. The only correctly translated key in this block is jp-payments. All other values need to be translated.
| "hero": { | ||
| "blurb1": "Creators of", | ||
| "blurb2": "lots of cool stuff", | ||
| "blurb3": "making life easier.", | ||
| "circularText": "Open Source ☆ Sugoi ☆ MikanDev ☆ Freedom ☆ ", | ||
| "primaryCta": "Take a Look", | ||
| "loop": "What makes us cool" | ||
| }, | ||
| "OpenSource": "Everything. Open. Source.", | ||
| "OpenSourceBlurb": "We believe in freedom and openness. Every single one of our projects and services are open source and available for anyone to use, modify, and distribute. Check out our GitHub to see what we're working on!", |
There was a problem hiding this comment.
The translations in the hero object, as well as for OpenSource and OpenSourceBlurb, are in English. They need to be translated into Japanese for this localization file.
| "ossProducts": { | ||
| "karaSnap": { | ||
| "title": "KaraSnap", | ||
| "description": "The easiest karaoke logging app ever, powered by AI" | ||
| }, | ||
| "nextDiscordAuth": { | ||
| "title": "Next Discord Auth", | ||
| "description": "Simple, no-nonsense Discord OAuth for your Next.js apps" | ||
| } | ||
| } |
There was a problem hiding this comment.
The translations for ossProducts within the home object are in English. These should be in Japanese. For example, "title": "KaraSnap" and its description need to be translated.
| "ossProducts": { | ||
| "viewRepo": "View Repository", | ||
| "visitSite": "Visit Website" | ||
| } |
There was a problem hiding this comment.
These ossProducts translations are in English. They should be translated to Japanese.
1 participant
No description provided.