Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Conversation

@iamatsundere
Copy link

update storage.s3.bucket quote character

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iamatsundere

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

Welcome @iamatsundere! It looks like this is your first PR to milvus-io/milvus-helm 🎉

@LoveEachDay
Copy link
Contributor

@iamatsundere Nice catch. Could you make the commit with -s to pass dco check and also make sure rebase the commits into one?

update storage.s3.bucket quote character

Signed-off-by: phuctt <[email protected]>
@iamatsundere
Copy link
Author

@LoveEachDay I just signed the commit and check it's the latest with branch 1.1. Please check it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants