Skip to content

Conversation

@sparknack
Copy link
Contributor

issue: #41435

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 16, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 84.70588% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.94%. Comparing base (ac062c6) to head (7602e12).
⚠️ Report is 1 commits behind head on master.

⚠️ Current head 7602e12 differs from pull request most recent head 633cc3c

Please upload reports for the commit 633cc3c to get more accurate results.

Files with missing lines Patch % Lines
internal/querynodev2/segments/manager.go 83.33% 3 Missing and 1 partial ⚠️
internal/querynodev2/segments/segment.go 80.00% 2 Missing and 1 partial ⚠️
internal/rootcoord/quota_center.go 81.25% 2 Missing and 1 partial ⚠️
pkg/util/paramtable/quota_param.go 81.25% 2 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (76.94%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #44893      +/-   ##
==========================================
- Coverage   77.01%   76.94%   -0.07%     
==========================================
  Files        1830     1818      -12     
  Lines      285091   283281    -1810     
==========================================
- Hits       219562   217973    -1589     
+ Misses      58362    58169     -193     
+ Partials     7167     7139      -28     
Components Coverage Δ
Client 78.03% <ø> (ø)
Core 83.90% <ø> (ø)
Go 75.06% <84.70%> (-0.08%) ⬇️
Files with missing lines Coverage Δ
internal/querynodev2/metrics_info.go 79.55% <100.00%> (-7.95%) ⬇️
internal/querynodev2/segments/utils.go 55.12% <100.00%> (+3.03%) ⬆️
internal/querynodev2/segments/segment.go 62.59% <80.00%> (+0.10%) ⬆️
internal/rootcoord/quota_center.go 78.73% <81.25%> (-0.28%) ⬇️
pkg/util/paramtable/quota_param.go 75.60% <81.25%> (+0.05%) ⬆️
internal/querynodev2/segments/manager.go 72.88% <83.33%> (+0.49%) ⬆️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sparknack sparknack force-pushed the seg-ld-v2 branch 2 times, most recently from d66a8ef to e732c3b Compare October 16, 2025 10:00
@sparknack
Copy link
Contributor Author

/ci-rerun-ut-integration

@mergify mergify bot added ci-passed and removed ci-passed labels Oct 16, 2025
@bigsheeper
Copy link
Contributor

/lgtm

@bigsheeper
Copy link
Contributor

better to add an integration test for it

@sre-ci-robot sre-ci-robot added area/test size/XL Denotes a PR that changes 500-999 lines. sig/testing test/integration integration test and removed lgtm size/L Denotes a PR that changes 100-499 lines. labels Oct 19, 2025
@mergify mergify bot removed the ci-passed label Oct 19, 2025
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Oct 19, 2025
@mergify mergify bot added the ci-passed label Oct 19, 2025
Copy link
Collaborator

@zhengbuqian zhengbuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sparknack, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9351608 into milvus-io:master Oct 19, 2025
15 of 18 checks passed
sre-ci-robot pushed a commit that referenced this pull request Oct 19, 2025
… load failures of querynode (#44932)

issue: #41435 
pr: #44893

---------

Signed-off-by: Shawn Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants