Skip to content

Conversation

junjiejiangjjj
Copy link
Contributor

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: junjiejiangjjj
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file area/internal-api area/test sig/testing labels Oct 16, 2025
Copy link
Contributor

mergify bot commented Oct 16, 2025

@junjiejiangjjj

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  • build(deps): for dependency updates from Dependabot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

@junjiejiangjjj junjiejiangjjj changed the title Support add_function/alter_function/drop_function enhance : Support add_function/alter_function/drop_function Oct 16, 2025
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 81.07477% with 162 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.97%. Comparing base (ac062c6) to head (92f7101).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/impl.go 63.51% 45 Missing and 9 partials ⚠️
internal/rootcoord/function_task.go 83.20% 37 Missing and 5 partials ⚠️
internal/proxy/function_task.go 90.00% 14 Missing and 4 partials ⚠️
...nternal/distributed/proxy/httpserver/request_v2.go 17.64% 14 Missing ⚠️
...nternal/distributed/proxy/httpserver/handler_v2.go 80.95% 10 Missing and 2 partials ⚠️
internal/coordinator/mix_coord.go 0.00% 6 Missing ⚠️
internal/distributed/mixcoord/service.go 0.00% 6 Missing ⚠️
internal/distributed/proxy/service.go 0.00% 6 Missing ⚠️
internal/metastore/kv/rootcoord/kv_catalog.go 75.00% 2 Missing and 1 partial ⚠️
cmd/tools/migration/mmap/mmap_230_240.go 0.00% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (76.97%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #44895      +/-   ##
==========================================
- Coverage   77.01%   76.97%   -0.04%     
==========================================
  Files        1830     1832       +2     
  Lines      285091   285937     +846     
==========================================
+ Hits       219562   220111     +549     
- Misses      58362    58613     +251     
- Partials     7167     7213      +46     
Components Coverage Δ
Client 78.03% <ø> (ø)
Core 83.90% <ø> (ø)
Go 75.09% <81.16%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
internal/distributed/mixcoord/client/client.go 87.05% <100.00%> (+0.26%) ⬆️
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/proxy/task.go 78.15% <ø> (-0.16%) ⬇️
internal/rootcoord/meta_table.go 78.20% <100.00%> (+0.13%) ⬆️
internal/rootcoord/root_coord.go 78.06% <100.00%> (+1.11%) ⬆️
internal/rootcoord/step.go 83.70% <100.00%> (ø)
...util/function/embedding/text_embedding_function.go 89.40% <ø> (ø)
internal/util/mock/grpc_rootcoord_client.go 84.17% <100.00%> (+0.71%) ⬆️
cmd/tools/migration/mmap/mmap_230_240.go 0.00% <0.00%> (ø)
internal/metastore/kv/rootcoord/kv_catalog.go 76.28% <75.00%> (-0.07%) ⬇️
... and 8 more

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@junjiejiangjjj junjiejiangjjj changed the title enhance : Support add_function/alter_function/drop_function feat: Support add_function/alter_function/drop_function Oct 16, 2025
@mergify mergify bot added kind/feature Issues related to feature request from users and removed do-not-merge/invalid-pr-format labels Oct 16, 2025
Copy link
Contributor

mergify bot commented Oct 16, 2025

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@junjiejiangjjj junjiejiangjjj force-pushed the func-patch branch 5 times, most recently from 89fb9c5 to 913687b Compare October 18, 2025 14:41
@junjiejiangjjj
Copy link
Contributor Author

/assign @liliu-z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users sig/testing size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants