Skip to content

Conversation

@chyezh
Copy link
Contributor

@chyezh chyezh commented Oct 17, 2025

issue: #44924

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 17, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 17, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.00%. Comparing base (9c2aeaa) to head (a895711).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/expr/ITypeExpr.h 36.36% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #44925      +/-   ##
==========================================
+ Coverage   74.35%   77.00%   +2.64%     
==========================================
  Files        1324     1831     +507     
  Lines      207178   285023   +77845     
==========================================
+ Hits       154051   219472   +65421     
- Misses      45973    58395   +12422     
- Partials     7154     7156       +2     
Components Coverage Δ
Client 78.03% <ø> (ø)
Core 84.01% <36.36%> (∅)
Go 75.08% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/exec/expression/Utils.h 61.32% <ø> (ø)
internal/core/src/query/PlanProto.cpp 80.60% <ø> (ø)
internal/core/src/expr/ITypeExpr.h 54.54% <36.36%> (ø)

... and 521 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f98d02b into milvus-io:master Oct 20, 2025
16 of 18 checks passed
sre-ci-robot pushed a commit that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants