Skip to content

Feature/mbx 3390 inapp targeting api call #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Vailence wants to merge 2 commits into from
Closed

Feature/mbx 3390 inapp targeting api call #460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d4aac4
MBX-3390 Update trigger event
Nov 7, 2024
c75955b
MBX-3390 mini refactor
Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Mindbox/InAppMessages/InAppConfigurationMapper/InAppConfigutationMapper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ final class InAppConfigutationMapper: InAppConfigurationMapperProtocol {
}

func filterByInappsEvents(inapps: [InApp], filteredInAppsByEvent: inout [InAppMessageTriggerEvent: [InAppTransitionData]]) {
for inapp in inapps {
var triggerEvent: InAppMessageTriggerEvent = .start
var triggerEvent: InAppMessageTriggerEvent = savedEventForTargeting.map { .applicationEvent($0) } ?? .start

for inapp in inapps {
let inAppAlreadyAddedForEvent = filteredInAppsByEvent[triggerEvent]?.contains(where: { $0.inAppId == inapp.id }) ?? false

// If the in-app message has already been added, continue to the next message
Expand All @@ -149,10 +149,6 @@ final class InAppConfigutationMapper: InAppConfigurationMapperProtocol {
continue
}

if let event = targetingChecker.event {
triggerEvent = .applicationEvent(event)
}

var inAppsForEvent = filteredInAppsByEvent[triggerEvent] ?? [InAppTransitionData]()
if let inAppFormVariants = inapp.form.variants.first {
let formData = InAppTransitionData(inAppId: inapp.id,
Expand Down
Loading