mirage-crypto-ec: add Brainpool curves with 254/384/512 bits #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modularizes the point representation in preparation for the SECP256K1 implementation, which is based on ECCKiila and uses a different point representation.
This change implements the SECP256K1 curve (also known as the Bitcoin curve). - field primitives are generated by the fiat-crypto project[1] - point primitives are generated by the ECCKiila project[2] - Ocaml point operations are taken from NIST implementation, adapted to ECCKiila point primitives and optimized for a=0. - testvectors for ECDH and ECDSA verification from wycheproof[3] Closes: mirage#187 [1] https://github.com/mit-plv/fiat-crypto [2] https://gitlab.com/nisec/ecckiila [3] https://github.com/C2SP/wycheproof
ansiwen
force-pushed
the
brainpool
branch
2 times, most recently
from
a10936b to
1a26204
Compare
|
Setting to "ready for review" although some CI tests are failing. Not sure why. Any clue how this can happen, but only for 4.14.2 on ubuntu and windows? Is there maybe a cache issue (because the file was indeed missing before)? |
Answering myself: Mac is case-insensitive, and the files in |
This change adds the Brainpool curves, namely brainpoolP254r1, brainpoolP384r1, brainpoolP512r1. The implementation internally uses the twisted versions of the curves (...t1) in order to use the same a=-3 EC arithmetic as the NIST curves. Point coordinates in regular form are transformed to twisted form before calculations, and vice versa afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the Brainpool curves, namely brainpoolP254r1,
brainpoolP384r1, brainpoolP512r1. The implementation internally uses the
twisted versions of the curves (...t1) in order to use the same a=-3 EC
arithmetic as the NIST curves. Point coordinates in regular form are
transformed to twisted form before calculations, and vice versa afterwards.
Based on: #259, merge that first