Skip to content

Conversation

iafilin
Copy link

@iafilin iafilin commented Mar 1, 2025

No description provided.

@kevinvalk
Copy link

kevinvalk commented Apr 25, 2025

Note to self: always important to check open PRs! Anyways, you removed a bit too much here. You can still pass on the query and onEdit parameters.

        {% if enable_explorer_plugin %}
        var explorerPlugin = GraphiQLPluginExplorer.explorerPlugin({
          query: query,
          onEdit: setQuery,
        });
        {% endif %}

That said, it seems that query and setQuery is not needed anymore so the whole AriadneGraphiQL function can be simplified to

      function AriadneGraphiQL() {
        {% if enable_explorer_plugin %}
        var explorerPlugin = GraphiQLPluginExplorer.explorerPlugin();
        {% endif %}
        return React.createElement(GraphiQL, {
          fetcher: fetcher,
          defaultEditorToolsVisibility: true,
          {% if enable_explorer_plugin %}
          plugins: [explorerPlugin],
          {% endif %}
        });
      }

@iafilin would you mind adjusting this PR?

P.S. You also need to fix the test snapshots, do you need any help with that?

@DamianCzajkowski
Copy link
Collaborator

Hi @iafilin @kevinvalk, are you still interested in completing this PR, or would you like some assistance with getting it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants