Skip to content

fix: use angle brackets for includes under include/mitie#226

Open
peter277 wants to merge 1 commit intomit-nlp:masterfrom
peter277:fix-include-style-angle-brackets
Open

fix: use angle brackets for includes under include/mitie#226
peter277 wants to merge 1 commit intomit-nlp:masterfrom
peter277:fix-include-style-angle-brackets

Conversation

@peter277
Copy link
Copy Markdown
Contributor

@peter277 peter277 commented Feb 28, 2026

Makes include style and resolution behaviour consistent across include/mitie. Angle brackets are already the main convention.

@davisking
Copy link
Copy Markdown
Contributor

Why though? Is this fixing something? This has the possibility to break certain user's build systems.

@peter277
Copy link
Copy Markdown
Contributor Author

peter277 commented Mar 3, 2026

Why though? Is this fixing something? This has the possibility to break certain user's build systems.

The motivation is include resolution safety and consistency. I'm using MITIE in an MSYS2 package alongside an external dlib, and mixing quoted includes and angle brackets creates a risk of mis-resolution if a nearby directory contains similarly named headers. I would rather avoid patching this downstream, hence submitting the PR.

Angle brackets are also already the prevailing convention in include/mitie (for example:

#include <dlib/uintn.h>
#include <dlib/serialize.h>
and
#include <dlib/hash.h>
#include <dlib/svm.h>
#include <dlib/serialize.h>
#include <vector>
#include <mitie/total_word_feature_extractor.h>
among many others), so this change just aligns the remaining headers.

Could you outline a concrete scenario in which switching these to angle brackets would break a build? From my perspective, this is low risk and may actually prevent subtle issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants