Conversation
There was a problem hiding this comment.
Thanks for your substantial effort in preparing this PR!
Looking at the preview image, it appears quite similar to the awesomecv template with improved customisation for fonts. If my quick look is correct, could we instead extend the awesomecv template to support more font options (similarly to what was done in #278)?
To reduce the maintenance burden of the vitae package, I'm reluctant to merge in templates which are visually similar to existing templates. I'm currently working on a quarto variant of the vitae package which could be better suited for a template like this.
| new_entry_formats <- function(brief, detailed) { | ||
| list(brief = brief, detailed = detailed) | ||
| new_entry_formats <- function(brief, detailed, honor = NULL, skill = NULL) { | ||
| formats <- list(brief = brief, detailed = detailed) |
There was a problem hiding this comment.
Could we directly add honor and skill into the list (even if it is NULL), so that later access to $honor and $skill don't implicitly return NULL values?
| file.copy(file.path(path, f), ".", recursive = TRUE) | ||
| source <- file.path(path, f) | ||
| target <- f | ||
| if (file_different(source, target)) { |
There was a problem hiding this comment.
This change will break a common usage of the package, where users commonly directly edit the copied resource files to change the style of the document. As such, these files only be copied and not replaced.
Perhaps an added argument to cv_document for replacing resources would be a good compromise? Currently users simply delete the files if they want to update or reset them.
Hi Mitchell, I just added a new template 'crisp', which has the following features:
address,email, etc.I made this template when I prepared my resume and hope that this may help others, too. Thank you for making this great vitae R package.