feat: implement Validated base class and refactor TechniqueImpl #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Validated base class with Zod schema integration - Refactor TechniqueImpl to use new architecture pattern - Replace interface declaration merging with schema-based approach - Add comprehensive relationship management with private fields - Include domain-specific utility methods (getAttackId, supportsPlatform, etc.) - Add technique-impl.example.ts demonstrating usage patterns - Remove TypeScript linting suppressions from implementation This proof of concept establishes the foundation for overhauling all *Impl classes to eliminate declaration merging workarounds and improve type safety.
7 tasks
7 tasks
7 tasks
- Rename DataSourceOptions → ContentOriginOptions - Rename DataSourceRegistration → ContentOriginRegistration - Rename registerDataSource() → registerContentOrigin() - Rename DataSourceMap → ContentOriginMap - Rename dataSources variable → contentOrigins - Change 'attack' source option to 'mitre' for clarity - Update all documentation in README.md, docs/, and docusaurus/docs/ - Update error messages and comments throughout codebase BREAKING CHANGE: API functions and types have been renamed. Update imports to use ContentOriginRegistration and registerContentOrigin instead of DataSourceRegistration and registerDataSource. Change source: 'attack' to source: 'mitre' in configurations.
- Refinements have been moved from @/refinements to @/schemas/refinements - Update downstream references accordingly
- Generator has been moved to the utils sub-package - Update downstream references accordingly
- Update test modules in test/documentation - Update references to content origin (from data source) - Update import paths - Fix some small type hinting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proof of concept establishes the foundation for overhauling all *Impl classes to eliminate declaration merging workarounds and improve type safety.