Skip to content

Fix bug with the incorrect interpretation of feature numbers 0, 10 and 13 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oswalpalash wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bug with the incorrect interpretation of feature numbers 0, 10 and 13 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fob/src/firmware.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ void enableFeature(FLASH_DATA *fob_state_ram)
{
if (fob_state_ram->paired == FLASH_PAIRED)
{
uint8_t uart_buffer[20];
uint8_t uart_buffer[24];
uart_readline(HOST_UART, uart_buffer);

ENABLE_PACKET *enable_message = (ENABLE_PACKET *)uart_buffer;
Expand All @@ -286,6 +286,8 @@ void enableFeature(FLASH_DATA *fob_state_ram)
return;
}

enable_message->feature = (uint8_t)atoi((char *)uart_buffer + 8);

// Feature list full
if (fob_state_ram->feature_info.num_active == NUM_FEATURES)
{
Expand Down Expand Up @@ -370,4 +372,4 @@ uint8_t receiveAck()
receive_board_message_by_type(&message, ACK_MAGIC);

return message.buffer[0];
}
}
3 changes: 2 additions & 1 deletion host_tools/package_tool
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ def package(package_name, car_id, feature_number):
# Create package to match defined structure on fob
package_message_bytes = (
str.encode(car_id + car_id_pad)
+ feature_number.to_bytes(1, "little")
# encode feature number as string and pad to 3 bytes
+ str.encode(str(feature_number).zfill(3))
+ str.encode("\n")
)

Expand Down