-
Notifications
You must be signed in to change notification settings - Fork 31
Add ending time to challenges #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
camdenmoors
wants to merge
17
commits into
mitre-cyber-academy:master
Choose a base branch
from
camdenmoors:challenge-end
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2cd65e9
Add challenge end time to db
camdenmoors a3bcc9c
Fix DB schema
camdenmoors ce7ce11
Add a check if the challenge is closed
camdenmoors 3f0ea6b
Ensure that the game actually closes when its past the stop date
camdenmoors 4c41968
Merge branch 'master' into challenge-end
camdenmoors 97354f1
Use shorter syntax for checking if it's passed the challenge end
camdenmoors 55866d1
Merge branch 'challenge-end' of https://github.com/camdenmoors/ctf-sc…
camdenmoors b9d9435
Empty line after return statement
camdenmoors c8d19b2
Typo in test name
camdenmoors 4034c6a
Remove trailing whitespace
camdenmoors 1c65515
Remove challenge_end and add open/close_challenge_at
camdenmoors ca85155
Rename challenge_end to close_challenge_at
camdenmoors 7983ec9
Remove two unneeded migrations
camdenmoors 47da91a
More testing for challenge opening
camdenmoors 625281d
Put stop_calculation_at in defense/share challenges
camdenmoors d860561
Merge branch 'master' into challenge-end
camdenmoors 112284a
Merge branch 'master' into challenge-end
camdenmoors File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddChallengeEndTime < ActiveRecord::Migration[6.0] | ||
def change | ||
add_column :challenges, :challenge_end, :datetime | ||
camdenmoors marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.