Issue 452: Added the assertion for consistency check and evaluation frequency check #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of eva is aligned with expectations with real wall_clock_time
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this PR, I added two assertions to validate the timing and evaluation consistency at the end of the training loop:
Duration consistency check: The total duration of training (submission time + logging time + evaluation time) is asserted to match the final evaluation result's total_duration, with a tolerance of 10 seconds.
Evaluation frequency check: Ensures the number of evaluations does not exceed the allowed evaluations based on the accumulated submission time and the workload's evaluation period.