-
Notifications
You must be signed in to change notification settings - Fork 90
Fix TFDS example #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix TFDS example #853
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Right, thanks! Can you sign the MLCommons Association CLA first? See https://mlcommons.org/community/subscribe/ |
|
@ccl-core Working on it, LBNL/NERSC ( my employer ) has signed it, just trying to get added to it. We emailed [email protected], it that the right place for this request? |
|
recheck |
|
@ccl-core Should be good now. |
README.md
Outdated
| builder.download_and_prepare() | ||
| # 4. Split for training/testing | ||
| train, test = builder.as_data_source(split=['default[:80%]', 'default[80%:]']) | ||
| train, test = builder.as_data_source(split=['train[:80%]', 'test[80%:]']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 80% split was, IIRC, just to make up for the missing split definiton in the early croissant definitions for huggingface dataset. Can't you just train, test = builder.as_data_source(split=['train', 'test']) ?
|
Looks good, thanks! Can you please fix the |
Done |
Looks like the record set name has changed also with the split names.
Looks like the record set name has changed also with the split names.