Skip to content

Conversation

@cjh1
Copy link

@cjh1 cjh1 commented Apr 16, 2025

Looks like the record set name has changed also with the split names.

@cjh1 cjh1 requested a review from a team as a code owner April 16, 2025 15:52
@github-actions
Copy link

github-actions bot commented Apr 16, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@ccl-core
Copy link
Contributor

Right, thanks! Can you sign the MLCommons Association CLA first? See https://mlcommons.org/community/subscribe/

@ccl-core ccl-core self-requested a review April 19, 2025 02:52
@cjh1
Copy link
Author

cjh1 commented Apr 21, 2025

@ccl-core Working on it, LBNL/NERSC ( my employer ) has signed it, just trying to get added to it. We emailed [email protected], it that the right place for this request?

@cjh1
Copy link
Author

cjh1 commented Apr 21, 2025

recheck

@cjh1
Copy link
Author

cjh1 commented Apr 21, 2025

@ccl-core Should be good now.

README.md Outdated
builder.download_and_prepare()
# 4. Split for training/testing
train, test = builder.as_data_source(split=['default[:80%]', 'default[80%:]'])
train, test = builder.as_data_source(split=['train[:80%]', 'test[80%:]'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 80% split was, IIRC, just to make up for the missing split definiton in the early croissant definitions for huggingface dataset. Can't you just train, test = builder.as_data_source(split=['train', 'test']) ?

@ccl-core
Copy link
Contributor

Looks good, thanks! Can you please fix the 80% reference in the code snippet?

@cjh1 cjh1 force-pushed the fix-tfds-readme branch from 0afaa79 to 91e0abe Compare April 24, 2025 20:34
@cjh1
Copy link
Author

cjh1 commented Apr 24, 2025

Looks good, thanks! Can you please fix the 80% reference in the code snippet?

Done

Looks like the record set name has changed also with the split
names.
@cjh1 cjh1 force-pushed the fix-tfds-readme branch from 91e0abe to 021fac6 Compare April 24, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants