in README, link to spec #887
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same link shown at https://mlcommons.org/working-groups/data/croissant/
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
ccl-core
reviewed
Jun 10, 2025
|
|
||
| ## Resources | ||
|
|
||
| - [Specification](https://docs.mlcommons.org/croissant/docs/croissant-spec.html) |
Member
Author
There was a problem hiding this comment.
Should I make this change? Please feel free to push to my branch!
ccl-core
reviewed
Jun 10, 2025
|
|
||
| - [Specification](https://docs.mlcommons.org/croissant/docs/croissant-spec.html) | ||
| - [Github Repo](https://github.com/mlcommons/croissant) | ||
| - Specification |
Contributor
There was a problem hiding this comment.
Yeah, I think we could remove this line
Contributor
There was a problem hiding this comment.
Maybe we could add here something like "[mlcroissant code](link to python/mlcroissant)" instead
Member
Author
There was a problem hiding this comment.
As you wish. Please feel free to push a change.
ccl-core
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same link shown at https://mlcommons.org/working-groups/data/croissant/
Perhaps the spec could also be linked in the first paragraph. 🤷 This is a a start, at least. I was showing a friend the README and he asked where he could find the spec. We went to https://mlcommons.org/croissant and scrolled down to find it.
I'm aware that "Specification" also appears just below under "GitHub Repo". Perhaps this could link to the specs in progress? 🤷