Feat simple resource flow #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
|
@anhappdev could you please check why the windows build is failing? I don't have access to google cloud. Edit: seems like it passed on 2nd run |
freedomtan
approved these changes
Jun 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the resource downloading flow by removing the list of missing files from the warning dialog and making the "Download" button automatically start the download for necessary resources (instead of just going to the resources page).
It also changes the text of the dialog and the location of the "download all" button in accordance with #1013.
This PR is a bit rushed because of Wednesday's release, therefore I'll keep the related issue and branch, and experiment a little bit with making the flow even more straightforward after this is merged.