Skip to content

refactor: use custom setting in Core ML backend to detect NCHW input. #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2024
Merged

refactor: use custom setting in Core ML backend to detect NCHW input. #924

merged 3 commits into from
Nov 12, 2024

Conversation

@anhappdev
Copy link
Collaborator

@anhappdev anhappdev commented Oct 4, 2024 •
edited
Loading

The Core ML backend now uses

custom_setting {
      id: "data-format"
      value: "NCHW"
}

instead of hard-coded file name like mobilenetv4_fp32_NCHW to detect NCHW input.

I also add a GetConfigValue() method to easily read the config values.

@github-actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anhappdev anhappdev force-pushed the anh/use-custom-setting-in-backend branch 2 times, most recently from ce5d430 to 7722847 Compare October 24, 2024 11:32
@anhappdev anhappdev force-pushed the anh/use-custom-setting-in-backend branch from 7722847 to eb9eb2a Compare October 24, 2024 12:11
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@anhappdev anhappdev marked this pull request as ready for review October 29, 2024 02:18
@anhappdev anhappdev requested a review from a team as a code owner October 29, 2024 02:18
@freedomtan
Copy link
Contributor

@freedomtan to test it.

@anhappdev
Copy link
Collaborator Author

@freedomtan Can you please review this PR?

freedomtan
freedomtan approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@freedomtan freedomtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anhappdev anhappdev merged commit 1bddf37 into master Nov 12, 2024
22 checks passed
@anhappdev anhappdev deleted the anh/use-custom-setting-in-backend branch November 12, 2024 05:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@freedomtan freedomtan freedomtan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anhappdev @freedomtan