test_mosaic.py: update to reflect changes to mosaicobj#49
Open
hderry wants to merge 39 commits intomlee03:mainfrom
Open
test_mosaic.py: update to reflect changes to mosaicobj#49hderry wants to merge 39 commits intomlee03:mainfrom
hderry wants to merge 39 commits intomlee03:mainfrom
Conversation
- created the main program for make_mosaic with rough outline
- began outlining my ctypes wrapper for get_contact and created shared library to test function access
- created a draft of MosaicStruct and will make a proper unit test
- xarray vs netcdf4 package: unsure which is more suitable for mosaic file creation, may benefit mor
e from low-level interface, memory management, ... I can switch to xarray if needed and for uniformity.
i#
-Removed contact library -fixed typo in make_mosaic.py MosaicObj -Switched from netcdf4 to xarray package -used post_init to populate gridfiles and ntiles -> read_mosaic method & created file pointer for future use -implemented class method for generating grid dictionary -> need to work on making nested dict accessible
Merge branch 'main' of https://github.com/hderry/FMSgridtools
… additional changes in the future) -new directory for make_mosaic under pyfrenctools and ctypes wrapper for make_solo_mosaic (need to pull from pyFMS) -inital test file for mosaicobj and make_mosaic
…for regional data
*type hint functions in make_mosaic.py
…into make_mosaic
- Implemented subcommands with Click groups… with each subcommand having its own module - Updated test_mosaic.py to utilize CliRunner for testing click applications
-remove conversion of lists to np.arrays -> change to be refected on mosaicobj side as well. -use tile names directly in solo_mosaic
making new instance in solo_mosaic > grid = MosaicObj(args).griddict()
…ly without depending on importing input files
…type * change assert command
…into make_mosaic
rem1776
approved these changes
Jun 5, 2025
Owner
|
@hderry, carrying on our conversation here, after the tests pass with pytest, we'll merge it in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor changes to ensure test_mosaic.py passes