Skip to content

Fix remaining ty type errors in baker.py and generators.py #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amureki merged 2 commits into from
Mar 26, 2026
Merged

Fix remaining ty type errors in baker.py and generators.py #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a3932d
Fix ty type errors in baker.py
benaduo Mar 17, 2026
a23b065
Use type: ignore[list-item] instead of cast per reviewer preference
benaduo Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions model_bakery/baker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,13 +617,13 @@ def _skip_field(self, field: Field) -> bool: # noqa: C901
if isinstance(field, OneToOneField) and self._remote_field(field).parent_link:
return True

other_fields_to_skip = [
other_fields_to_skip: list[type] = [
AutoField,
OrderWrt,
]

if BAKER_CONTENTTYPES:
other_fields_to_skip.extend([GenericRelation, GenericForeignKey])
other_fields_to_skip.extend([GenericRelation, GenericForeignKey]) # type: ignore[list-item]

if isinstance(field, tuple(other_fields_to_skip)):
return True
Expand Down
4 changes: 2 additions & 2 deletions model_bakery/generators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
IntegerRangeField = None # type: ignore[misc,assignment]


default_mapping = {
default_mapping: dict[type, Callable] = {
ForeignKey: random_gen.gen_related,
OneToOneField: random_gen.gen_related,
ManyToManyField: random_gen.gen_m2m,
Expand Down Expand Up @@ -113,7 +113,7 @@
ImageField: random_gen.gen_image_field,
DurationField: random_gen.gen_interval,
JSONField: random_gen.gen_json,
} # type: dict[type, Callable]
}

if ArrayField:
default_mapping[ArrayField] = random_gen.gen_array
Expand Down