-
Notifications
You must be signed in to change notification settings - Fork 513
Fix structured output backwards compatibility for string results #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -257,10 +257,13 @@ public override async ValueTask<CallToolResult> InvokeAsync( | |||||||||
Content = [], | ||||||||||
StructuredContent = structuredContent, | ||||||||||
}, | ||||||||||
|
||||||||||
string text => new() | ||||||||||
{ | ||||||||||
Content = [new TextContentBlock { Text = text }], | ||||||||||
// If there is structuredOutput we must stringify it, as the MCP specification requires Content to be for backwards compatibility | ||||||||||
// but otherwise not differ | ||||||||||
Content = [new TextContentBlock { Text = structuredContent == null ? text : | ||||||||||
JsonSerializer.Serialize(structuredContent, AIFunction.JsonSerializerOptions.GetTypeInfo(typeof(object)))}], | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not just resolve the type of structuredContent itself and skip one degree of indirection?
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Good point, but this goes for the default switch case too then? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I suppose we can leave it for consistency. |
||||||||||
StructuredContent = structuredContent, | ||||||||||
}, | ||||||||||
|
||||||||||
|
Uh oh!
There was an error while loading. Please reload this page.