Skip to content

Add unit test for ElicitAsync<T> with no SerializationOptions #798 #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add unit test for ElicitAsync<T> with no SerializationOptions #798 #803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93725b3
Add a test for reflection-based serialization on non-AOT scenarios. #798
mehrandvd Sep 19, 2025
00a67d4
Update test for reflection-based ElicitAsync
mehrandvd Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 115 additions & 0 deletions tests/ModelContextProtocol.Tests/Protocol/ElicitationTypedTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,20 @@ protected override void ConfigureServices(ServiceCollection services, IMcpServer
Assert.Equal(SampleRole.Admin, result.Content!.Role);
Assert.Equal(99.5, result.Content!.Score);
}
else if (request.Params!.Name == "TestElicitationTypedNoSerializationOptions")
{
var result = await request.Server.ElicitAsync<SampleForm>(
message: "Please provide more information.",
cancellationToken: CancellationToken.None);

Assert.Equal("accept", result.Action);
Assert.NotNull(result.Content);
Assert.Equal("Alice", result.Content!.Name);
Assert.Equal(30, result.Content!.Age);
Assert.True(result.Content!.Active);
Assert.Equal(SampleRole.Admin, result.Content!.Role);
Assert.Equal(99.5, result.Content!.Score);
}
else if (request.Params!.Name == "TestElicitationCamelForm")
{
var result = await request.Server.ElicitAsync<CamelForm>(
Expand Down Expand Up @@ -194,6 +208,107 @@ public async Task Can_Elicit_Typed_Information()
Assert.Equal("success", (result.Content[0] as TextContentBlock)?.Text);
}

[Fact]
public async Task Can_Elicit_Typed_Information_No_SerializationOptions()
{
if (JsonSerializer.IsReflectionEnabledByDefault is false)
{
Assert.Skip("Reflection is disabled by default. This test requires reflection to be enabled.");
}

await using McpClient client = await CreateMcpClientForServer(new McpClientOptions
{
Capabilities = new()
{
Elicitation = new()
{
ElicitationHandler = async (request, cancellationToken) =>
{
Assert.NotNull(request);
Assert.Equal("Please provide more information.", request.Message);

Assert.Equal(6, request.RequestedSchema.Properties.Count);

foreach (var entry in request.RequestedSchema.Properties)
{
var key = entry.Key;
var value = entry.Value;
switch (key)
{
case "name":
var stringSchema = Assert.IsType<ElicitRequestParams.StringSchema>(value);
Assert.Equal("string", stringSchema.Type);
break;

case "age":
var intSchema = Assert.IsType<ElicitRequestParams.NumberSchema>(value);
Assert.Equal("integer", intSchema.Type);
break;

case "active":
var boolSchema = Assert.IsType<ElicitRequestParams.BooleanSchema>(value);
Assert.Equal("boolean", boolSchema.Type);
break;

case "role":
var enumSchema = Assert.IsType<ElicitRequestParams.EnumSchema>(value);
Assert.Equal("string", enumSchema.Type);
Assert.Equal([nameof(SampleRole.User), nameof(SampleRole.Admin)], enumSchema.Enum);
break;

case "score":
var numSchema = Assert.IsType<ElicitRequestParams.NumberSchema>(value);
Assert.Equal("number", numSchema.Type);
break;

case "created":
var dateTimeSchema = Assert.IsType<ElicitRequestParams.StringSchema>(value);
Assert.Equal("string", dateTimeSchema.Type);
Assert.Equal("date-time", dateTimeSchema.Format);

break;

default:
Assert.Fail($"Unexpected property in schema: {key}");
break;
}
}

return new ElicitResult
{
Action = "accept",
Content = new Dictionary<string, JsonElement>
{
[nameof(SampleForm.Name)] = (JsonElement)JsonSerializer.Deserialize("""
"Alice"
""", McpJsonUtilities.DefaultOptions.GetTypeInfo(typeof(JsonElement)))!,
[nameof(SampleForm.Age)] = (JsonElement)JsonSerializer.Deserialize("""
30
""", McpJsonUtilities.DefaultOptions.GetTypeInfo(typeof(JsonElement)))!,
[nameof(SampleForm.Active)] = (JsonElement)JsonSerializer.Deserialize("""
true
""", McpJsonUtilities.DefaultOptions.GetTypeInfo(typeof(JsonElement)))!,
[nameof(SampleForm.Role)] = (JsonElement)JsonSerializer.Deserialize("""
"Admin"
""", McpJsonUtilities.DefaultOptions.GetTypeInfo(typeof(JsonElement)))!,
[nameof(SampleForm.Score)] = (JsonElement)JsonSerializer.Deserialize("""
99.5
""", McpJsonUtilities.DefaultOptions.GetTypeInfo(typeof(JsonElement)))!,
[nameof(SampleForm.Created)] = (JsonElement)JsonSerializer.Deserialize("""
"2023-08-27T03:05:00"
""", McpJsonUtilities.DefaultOptions.GetTypeInfo(typeof(JsonElement)))!,
},
};
},
},
},
});

var result = await client.CallToolAsync("TestElicitationTypedNoSerializationOptions", cancellationToken: TestContext.Current.CancellationToken);

Assert.Equal("success", (result.Content[0] as TextContentBlock)?.Text);
}

[Fact]
public async Task Elicit_Typed_Respects_NamingPolicy()
{
Expand Down
Loading