mcp: allow injecting custom streams in StdioTransport #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional In and Out fields to StdioTransport to allow injection of custom io.ReadCloser and io.WriteCloser streams. This enables testing with io.Pipe() instead of requiring os.Stdin/os.Stdout. The Connect method now checks for nil fields and uses os.Stdin/os.Stdout as defaults.
|
This is redundant with #376, which introduces a general IOTransport. I'd like to keep StdioTransport and CmdTransport as distinct types. Also, for testing in memory, use NewInMemoryTransports, which creates two transports connected to eachother. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
StdioTransportwas hardcoded to useos.Stdinandos.Stdout, making it difficult to test transport behavior with controlled input/output. With this change, users can inject custom streams (likeio.Pipe()) for testing while maintaining backward compatibility.This change modifies the
Connectmethod to check the fields, defaulting back to the standard streams as defaults if nil.