fix(oauth): fix oauth credential refresh when the original token exchange was done in a different process #509
+10
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-core
alexhancock
approved these changes
Nov 4, 2025
auth.rs was using an in-memory expires-at which is only set on initial token exchange. Instead, this PR switches it to use the expires-at set in the credentials that are passed in.
gpeal
force-pushed
the
gpeal/refresh-token-fix
branch
from
c02f1b5 to
be2bc3e
Compare
Merged
gpeal
added a commit
to openai/codex
that referenced
this pull request
Nov 5, 2025
Picks up modelcontextprotocol/rust-sdk#509 which fixes #6164
|
The problem persists in 0.54 |
Contributor
|
@enriquemorenotent Do you mean 0.8.4 and above? cc @gpeal |
Holovkat
pushed a commit
to Holovkat/codex-pro
that referenced
this pull request
Nov 8, 2025
Picks up modelcontextprotocol/rust-sdk#509 which fixes openai/codex#6164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Codex has gotten internal and external reports of MCP servers frequently logging out (openai/codex#6164).
I tracked it down to the fact that auth.rs was using an in-memory expires-at which is only set on initial token exchange. Instead, this PR switches it to use the expires-at set in the credentials that are passed in.
How Has This Been Tested?
Validated with the notion mcp that it had an expired token, did not refresh the token before and does now.
Breaking Changes
None
Types of changes
Checklist