-
Notifications
You must be signed in to change notification settings - Fork 155
Upgrade TinyUSB to v0.16.0, allow dual role operations, fix HS port operations #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd1a51b to
e4dfeba
Compare
chris-durand
reviewed
Jan 4, 2024
ca5e61f to
a1f923d
Compare
a1f923d to
32f1e5f
Compare
32f1e5f to
5fb954e
Compare
rleh
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :)
Thanks!
5fb954e to
fb9358a
Compare
- Allow running device and host mode on separate ports at the same time. - Allow speed selection of HS port. - Correctly access all host and device class files.
To run the OTGHS port in FS mode the ULPI clock must be disabled.
The HS port can use both the DP and DM or the ULPI signals. All signals *must* be configured for high speed though!
fb9358a to
1f210c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a look at what TinyUSB is capable of now, it doesn't prevent you anymore from running Device and Host at the same time, so I refactored the code to allow generating both.
Also fixed some very embarrassing oversight of not configuring the USB pins for high speed, which prevented the ULPI signals from working. In addition, the HS port can also be used in FS mode, in which case the ULPI clock must remain disabled! This is now correctly being done, together with the GPIO config.
I don't have a way to test host mode, due to lack of the correct adapter. I would do that later and fix whatever is broken then.
TinyUSB changes:
STM32 changes:
all_peripheralsgenerator to:cmsis:device:peripheralsquery.Tested:
Host modeDual Mode