DMA for more STM32 controllers

[rleh]

This was very easy thanks to the great work done by @mikewolfram in #371.

Tested on Nucleo-F303RE.

[salkinium]

❤️

[rleh]

STM32F0{3,7}0xC / STM32F102 / devices modm-devices tells me about a second dma:stm32-channel-request instance that does not exist according to the datasheet and reference manual. Where does this come from and how do I fix it?

https://github.com/modm-io/modm-devices/blob/develop/devices/stm32/stm32f0-30.xml#L217

[rleh]

STM32F09{1,8} has a different problem:

<vector position="10" name="DMA1_Ch2_3_DMA2_Ch1_2"/>
<vector position="11" name="DMA1_Ch4_7_DMA2_Ch3_5"/>

---

I don't understand this error by now:

 x   stm32f373vct7          14.9s
In file included from modm/src/modm/platform.hpp:26,
                 from main.cpp:12:
modm/src/modm/platform/dma/dma.hpp:787:63: error: too many template-parameter-lists
  787 | struct DmaController<1>::Channel<DmaBase::Channel::Channel7>::RequestMapping<Peripheral::Tim17, DmaBase::Signal::Ch1>
      |                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
modm/src/modm/platform/dma/dma.hpp:805:63: error: too many template-parameter-lists
  805 | struct DmaController<1>::Channel<DmaBase::Channel::Channel7>::RequestMapping<Peripheral::Tim17, DmaBase::Signal::Up>
      |                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
scons: *** [build/scons-release/main.o] Error 1

(occures on multiple devices)

---

The Dma-SpiMaster has some interrupt flag definitions missing on some devices, looks easy to fix...

---

Dma2 has only 2 channels on STM32L1?
-> No, there are 5 channels but modm-devices does not know about it.

<channels device-size="c" instance="2">
  <channel position="1">
    <signal driver="spi" instance="3" name="rx"/>
  </channel>
  <channel position="2">
    <signal driver="spi" instance="3" name="tx"/>
  </channel>
</channels>

---

Peripheral::Lpuart vs Peripheral::Lpuart1
... and Dac vs Dac1
... and Swpmi1

Maybe modm-devices is inconsistent/wrong here? (#608 (comment))

Miauu 🐈

[salkinium]

Uff, I didn't expect there to be that many problems. The code responsible for parsing the DMA data is here, there are a lot of corrections, some of which are described in the PR.

[rleh]

Looks to me like CubeMX data is partly wrong, also modm-devices is definitely wrong in some cases 😒

I'm not motivated to deal with this any further at the moment; maybe tomorrow I'll look into enabling DMA based on a positive list for some STM32s that I use.

[rleh]

Some other issues I discovered:

From time to time (when regenerating device file in modm-devices) lbuild completely refuses to acknowledge the existence of STM32F0*. Probably (again) some cache issue...

I can't run the CI script on my Linux, because Python is unable to locate lbuild

>>> import subprocess

>>> subprocess.run(["echo $PATH"], shell=True)
[...]:/opt/doxypress:~/.local/bin:~/bin:/opt/gcc-arm-none-eabi-10-2020-q4-major/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin
CompletedProcess(args=['echo $PATH'], returncode=0)

>>> subprocess.run(["lbuild --version"], shell=True)
/bin/sh: lbuild: Kommando nicht gefunden.
CompletedProcess(args=['lbuild --version'], returncode=127)

>>> subprocess.run(["which lbuild"], shell=True)
/home/rleh/.local/bin/lbuild
CompletedProcess(args=['which lbuild'], returncode=0)

>>> subprocess.run(["$(which lbuild) --version"], shell=True)
lbuild 1.16.1
CompletedProcess(args=['$(which lbuild) --version'], returncode=0)

WTF?!

Update: ~/.local/bin:~/bin is the problem: /home/user/.local/bin:/home/user/bin works.

[salkinium]

I'm not motivated to deal with this any further at the moment; maybe tomorrow I'll look into enabling DMA based on a positive list for some STM32s that I use.

Yeah, that's also what I would propose, I think this issue is overwhelming otherwise. It's very frustrating to work with the CubeMX data…

Probably (again) some cache issue...

I'm sorry… It's on my todo list for #390.

Python is unable to locate lbuild

No clue… I need to rewrite that to call lbuild directly instead of from the cmdline…

[rleh]

No clue… I need to rewrite that to call lbuild directly instead of from the cmdline…

I think thats a bad idea, because it will make debugging even harder (or in some cases nearly impossible).

[rleh]

modm/src/modm/platform/dma/dma.hpp:706:63: error: too many template-parameter-lists
  706 | struct DmaController<1>::Channel<DmaBase::Channel::Channel6>::RequestMapping<Peripheral::Tim1, DmaBase::Signal::Ch3>
      |                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The underlying problem are some duplicate entry in modm-devices:
https://github.com/modm-io/modm-devices/blob/develop/devices/stm32/stm32f1-00-c_d_e.xml#L181-L182

<signal driver="tim" instance="1" name="ch3"/>
<signal driver="tim" instance="1" name="ch3"/>